Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Issues Possible Today? #125

Open
brianjking opened this issue Feb 17, 2016 · 51 comments
Open

Updates to Issues Possible Today? #125

brianjking opened this issue Feb 17, 2016 · 51 comments

Comments

@aensley
Copy link

@aensley aensley commented Feb 17, 2016

I was wondering what new update you were pointing out until I clicked on the link. The template is preloaded. Nice! I certainly hope this is coming to everyone soon!

@aensley
Copy link

@aensley aensley commented Feb 17, 2016

@brianjking
Copy link
Author

@brianjking brianjking commented Feb 17, 2016

@aensley Yeah, it links out to this template for the issue body: https://github.com/owncloud/core/blob/master/issue_template.md

Also, above the title you can see a link to the contributing page https://github.com/owncloud/core/blob/master/CONTRIBUTING.md

@aensley
Copy link

@aensley aensley commented Feb 17, 2016

The link to the contributing file has been there as long as I've been using GH. The pre-loaded template is new to me though. Testing it out on my repo right now.

@aensley
Copy link

@aensley aensley commented Feb 17, 2016

It works on my repo! Awesome!

@brianjking
Copy link
Author

@brianjking brianjking commented Feb 17, 2016

@aensley Did you just create a issue_template.md file at the root of your repo and it automatically inserts this?

@aensley
Copy link

@aensley aensley commented Feb 17, 2016

Yes. Exactly. I'd give you a link, but it's a private repo.

@brianjking
Copy link
Author

@brianjking brianjking commented Feb 17, 2016

@aensley I can confirm it's working for me also! Cool!

Yeah, totally gapped about the contributing link always being there.

@looterz
Copy link

@looterz looterz commented Feb 17, 2016

This is awesome!

@joshmanders
Copy link

@joshmanders joshmanders commented Feb 17, 2016

Great news!

@tikotzky
Copy link

@tikotzky tikotzky commented Feb 17, 2016

The issue template in that repo was originally created in Jan 2013.

Did this functionality exist the whole time?

@joshmanders
Copy link

@joshmanders joshmanders commented Feb 17, 2016

Some plugins and that exist.

One thing I noticed is it uses issue_template.md for the source of it. I'd much rather have a setting page on the repo to set the markdown for it manually, I don't want a bunch of github specific files mucking up my repos.

@kentcdodds
Copy link
Contributor

@kentcdodds kentcdodds commented Feb 17, 2016

I'd much rather have a setting page on the repo to set the markdown for it manually, I don't want a bunch of github specific files mucking up my repos.

Agreed, but this is nice to have.

@joshmanders
Copy link

@joshmanders joshmanders commented Feb 17, 2016

Indeed it is. I'll welcome it with open arms.

@josegonzalez
Copy link

@josegonzalez josegonzalez commented Feb 17, 2016

Doesn't affect mobile web maybe?

@bfontaine
Copy link

@bfontaine bfontaine commented Feb 17, 2016

I'd much rather have a setting page on the repo to set the markdown for it manually, I don't want a bunch of github specific files mucking up my repos.

The issue with that is you couldn’t make PR to fix issues in the issue template itself.

@brianjking
Copy link
Author

@brianjking brianjking commented Feb 17, 2016

@joshmanders Yeah, I agree. However, this is a great addition (or potentially there the whole time without any documentation).

I'm not sure how it will impact things like Sphinx-Doc or Jekyll sites either having this random Markdown document in the root of the repo.

@brianjking
Copy link
Author

@brianjking brianjking commented Feb 17, 2016

@josegonzalez It doesn't work with Chrome on my Nexus 6P or ForkHub on Android. 😦

Either way, it's a start. 👍

@joshmanders
Copy link

@joshmanders joshmanders commented Feb 17, 2016

@bfontaine You have a valid point there.

@brianjking the repo shown in this issue has had the issue_template.md file since 2013. I assume it's part of a browser plugin or something that pre-fills in the issue with the contents for you if you have the plugin installed.

@Rican7
Copy link

@Rican7 Rican7 commented Feb 17, 2016

@brianjking I'm so curious... how did you find out about this? Just went to create an issue on a repo and found the feature by accident?

@svenluijten
Copy link

@svenluijten svenluijten commented Feb 17, 2016

@joshmanders I don't have any extension installed, tested in incognito as well. It seems to work for me.

@KellerFuchs
Copy link

@KellerFuchs KellerFuchs commented Feb 17, 2016

@joshmanders It's not a browser plugin: works for me on Tor Browser 5.5alpha with JS enabled (and no extra plugins)

@josegonzalez
Copy link

@josegonzalez josegonzalez commented Feb 17, 2016

@brianjking for sure :)

@joshmanders
Copy link

@joshmanders joshmanders commented Feb 17, 2016

@svenluijten & @KellerFuchs I never said this was a plugin, I was stating the issues_template.md from the owncloud/core repo is probably an artifact from such a plugin used by a member of the team there and GitHub just so happened to set that file as the trigger.

@iwaffles
Copy link

@iwaffles iwaffles commented Feb 17, 2016

Very cool stuff, thanks for sharing! Going to give this a shot!

@nobso
Copy link

@nobso nobso commented Feb 17, 2016

This works! Thanks.

@orliesaurus
Copy link

@orliesaurus orliesaurus commented Feb 17, 2016

This is really sick - thanks for listening!

justbur referenced this issue in syl20bnr/spacemacs Feb 17, 2016
@PVince81
Copy link

@PVince81 PVince81 commented Feb 17, 2016

If this turns out to be something that has been there the whole time without any documentation written about it...

ownCloud had that file since a very long time ago. We just discovered today when clicking on "New issue" that Github started using it. Could be luck that it was named that way already 😄

@aensley
Copy link

@aensley aensley commented Feb 17, 2016

My guess is that "GitHub is listening," saw this in the wild via a third-party, and integrated it natively using the same naming convention.

@captn3m0
Copy link

@captn3m0 captn3m0 commented Feb 17, 2016

The owncloud issue_template.md file has been there for 3 years: #1160 is the PR that added it and @LukasReschke doesn't mention any existing plugin there. Just a lucky fluke, I guess.

@joshmanders
Copy link

@joshmanders joshmanders commented Feb 17, 2016

@captn3m0 Interesting, was this a previous feature of github in 2013 and they removed it?

@LukasReschke
Copy link

@LukasReschke LukasReschke commented Feb 17, 2016

The owncloud issue_template.md file has been there for 3 years: #1160 is the PR that added it and @LukasReschke doesn't mention any existing plugin there. Just a lucky fluke, I guess.

This is correct. As far I am aware there is no plugin support for this and we have just used to link to this from our contributing.md file. (which was actually nearly always ignored 🙈)

As @PVince81 in #125 (comment) stated we discovered this today randomly while filing an issue. (see also HN)

@captn3m0 Interesting, was this a previous feature of github in 2013 and they removed it?

No.

@joshmanders
Copy link

@joshmanders joshmanders commented Feb 17, 2016

@LukasReschke sorry your HN article didn't get any traction. :(

@LukasReschke
Copy link

@LukasReschke LukasReschke commented Feb 17, 2016

@LukasReschke sorry your HN article didn't get any traction. :(

There's worse than that 😉 Happy to have this feature officially supported at least after having asked GitHub support like 1000 times for it 😄

lamont-granquist added a commit to chef/chef that referenced this issue Feb 17, 2016
See dear-github/dear-github#125

I think this keeps the ask fairly doable, while making sure to
cover the bases that we need covered 90+% of the time.
@svenluijten
Copy link

@svenluijten svenluijten commented Feb 17, 2016

@fommil
Copy link

@fommil fommil commented Feb 17, 2016

this is really fantastic. It'd be even better if new tickets opened in Preview mode so our lovely formatting was preserved 😄

@dear-github dear-github locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.