Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue_template.md #23738

Merged
merged 1 commit into from Feb 26, 2016
Merged

Add issue_template.md #23738

merged 1 commit into from Feb 26, 2016

Conversation

maclover7
Copy link
Contributor

This appears to be a new feature of GitHub.

See these links for more details:

[ci skip]

@maclover7 maclover7 added the docs label Feb 17, 2016
benchmarks, or other information.

Finally, if your pull request includes code changes that only affect
**documentation**, please amend your commit(s) to include `[ci skip]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be "documentation or comments" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedelman
Copy link

Might be good idea to move these into the .github directory.

Also: https://github.com/blog/2111-issue-and-pull-request-templates

If you're worried about the added clutter in the root directory of your project, we also added support for a .github/ folder. You can put CONTRIBUTING.md, ISSUE_TEMPLATE.md, and PULL_REQUEST_TEMPLATE.md files in .github/ and everything will work as expected.

@maclover7 maclover7 force-pushed the issue-template branch 2 times, most recently from cc93ce0 to 8d378f0 Compare February 17, 2016 21:14
@@ -0,0 +1,14 @@
### Steps to reproduce

(Provide either a sample application or create an executable test script using one of the templates [here](https://github.com/rails/rails/tree/master/guides/bug_report_templates))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on adding contributing link

request, mention that information here. This could include
benchmarks, or other information.

Finally, if your pull request includes code changes that only affect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part can include the contributing to documentation link.

@maclover7
Copy link
Contributor Author

Updated per comments.

rafaelfranca added a commit that referenced this pull request Feb 26, 2016
@rafaelfranca rafaelfranca merged commit feae5f4 into rails:master Feb 26, 2016
@maclover7 maclover7 deleted the issue-template branch February 26, 2016 03:00
@maclover7
Copy link
Contributor Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants