Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkDownload downloads file with incorrect filename #39

Closed
MercuryOoO opened this issue Dec 23, 2020 · 7 comments
Closed

MarkDownload downloads file with incorrect filename #39

MercuryOoO opened this issue Dec 23, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@MercuryOoO
Copy link

Chrome: 87.0.4280.88 (64 bits)
MarkDownload: 2.4.1
OS: Windows 10 (10.0.19042)
Issue Ref: #10

This issue seems to be related to Chrome download API as it was occurred( Issue 1008884: chrome download API downloads file with incorrect filename ) I'm not sure which party should solves this issue first. The same issue appears in different Chrome plugins (such as Save Images Issue ref ). If this problem cannot be solved temporarily, I hope someone can provide some temporary solutions, thank you!

@nikiluk
Copy link

nikiluk commented Jan 5, 2021

I confirm the same behavior in the Edge browser. Specifically, when the original title of the page contains /, the download splits the title into two, creates a nested structure where the filename has the last part of the title...

For example, when the title is "Coffee and Tea 24/7 restaurant", the resulting path will be

/Coffee and Tea 24/7 restaurant.md

Where the filename will be 7 restaurant.md

@deathau
Copy link
Owner

deathau commented Jan 6, 2021

@nikiluk, your issue appears to be #40, which I think I have now resolved.

@MercuryOoO I'm pretty sure yours is a duplicate of #10 (but with more info, so I might close #10 as the duplicate).
It seems to be related to specific other extensions somehow interfering. I know it's a pain, but could you try disabling some other download-related extensions and see if the problem goes away? Just to double check that it is a compatibility issue and there isn't something else going on.

@deathau deathau added the bug Something isn't working label Jan 6, 2021
@nikiluk
Copy link

nikiluk commented Jan 6, 2021

@deathau thank you! I've downloaded the repo to try the update.

  • I like the styling changes you did on options.html
  • BUG: for some reason after I attempted to save the webpage extension goes into an endless loop 🔁👀 consuming over 50% of the CPU
  • I've also attempted to create a customized Download path but it was not working in all the cases with the last version of the repo.

@deathau
Copy link
Owner

deathau commented Jan 6, 2021

@nikiluk yeah, I've got a bit of a WIP in there regarding an attempt to download images relative to the md file which is still buggy. You might have to go back a commit or two to find something stable

@MercuryOoO
Copy link
Author

@deathau Thanks for your advice. Although my issue is caused by “Nimbus Screenshot & Screen Video Recorder”, it is actually a deeper and more common issue. Exactly the same issue has been described clearly in the following places:


Since the issue has been marked as WontFix by upstream Google, you may close the issue.

@pinacle2000
Copy link

SingleFile addon can fix such bug by the following:
If the file name of a saved page looks like "56833935-156b-4d8c-a00f-19599c6513d3.html", disable the option "Misc > save pages in background". Reinstalling the browser may also fix this issue. You can find more info about this bug here. This bug has been closed by Google as "WontFix".

I hope MarkDownload addon can have similar configuration.

@cdpath
Copy link

cdpath commented Sep 14, 2022

For those who found this issue and still having hashed filename, just go to Options > Download Mode > Choose Content Link. It will give you correct filename, at the cost of downloading images been disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants