Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger #41

Open
olleharstedt opened this issue Mar 16, 2017 · 3 comments
Open

Add logger #41

olleharstedt opened this issue Mar 16, 2017 · 3 comments

Comments

@olleharstedt
Copy link

Logging should not be done by directly calling console.log, but by a proper logging class with logging levels as debug, trace and error. This should be able to turn off in production system.

@olleharstedt
Copy link
Author

I'm using this logger in my fork now: https://github.com/jonnyreeves/js-logger

@Lukenickerson
Copy link
Member

I've been hesitant to bring in additional libraries because I'm not sure how they play well with the license. This might be something worth looking into.

@olleharstedt
Copy link
Author

The logger uses MIT, which is more permissive than GPL, so it should be OK, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants