-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add namespace processing logic #143
Conversation
Thank you for the PR. I have checked and merged it. Also, just curious but is there any specific reason for using while loop to get the root namespace here instead of regex? |
There is no specific reason. When I read the documentation, I didn't notice that it is possible to do. It's later when I realized. You could change it maybe shorten the time.
|
@debanjandhar12 Sorry, it seems like there is expected behavior that is not being handled. When the option is off, parsens exist or not will bring deck change. For example, When I have root page do not have parsens, and I have already created card in leaf page, I add parsens property true won't take decks change. I think parsens property change will bring decks change. What do you think? |
For example, (In all the cases the parsens option is turn off)
|
Reproduced it. I think its because the note hash is not changing when properties of root namespace page is changing. I think adding the root namespace page to note hash calculation will fix it. I will try to fix it over the weekend before next release. |
Thanks for your contribution. 👍 |
I believe the issue should be fixed now. |
Did a lot of trivial work.
1.When the option is on, namespace are parsed permanently.
2.When the option is off and the root page has the property parsens is true, the namespace will still be parsed and will update on next sync.
Hope to merge.