Removed RedisShards & cleaned up RedisCluster class #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atais
force-pushed
the
refactor
branch
2 times, most recently
from
f267e7e
to
f013632
Compare
|
@atais Let me dig through the commits and check if there was any diff between clustering and sharding. I will go through it over the weekend and merge .. Thanks for the PR .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
After all the cleaning up in #244 I was finally able to see, that actually
RedisClusterandRedisShardsare the same thing. They just have a different implementation inside.They both are actually sharding the data across multiple hosts based on the key. Now when the class is 100 lines long it is so easy to see 😄
This contains #247
@debasishg what do you think?