Elevate XSocketAddressInUse to ERROR #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
approved these changes
May 6, 2020
|
Thanks! cc. @AdrianKoshka |
Errors where the socket address is in use will keep the server from connecting with clients. This should be reported as an ERROR instead of a warning. Also, if the retry time is shorter issues will be more obvious, since the error will cause the log to scroll visibly.
simons-public
force-pushed
the
elevate-bind-failure-to-error
branch
from
5dea634
to
b3349dd
Compare
|
Not sure why you force-pushed? I'm cautious to merge, just need to check that the force push won't affect the main Barrier commit history. Otherwise, looks fine to me. Thanks 👍 |
shymega
approved these changes
May 12, 2020
|
@shymega The force push was just to get my PR rebased after the |
|
OK, thanks for explaining 😄 Merging now, thanks again! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors where the socket address is in use will keep the server from connecting with clients. This should be reported as an ERROR instead of a warning. Also, if the retry time is shorter issues will be more obvious, since the error will cause the log to scroll visibly.
Related discussions #516, #652, #654