Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more functionality #10

Closed
debck opened this issue Nov 14, 2018 · 14 comments
Closed

Add more functionality #10

debck opened this issue Nov 14, 2018 · 14 comments
Labels
Expert: 50 points Intermediate open OpenCode19

Comments

@debck
Copy link
Owner

debck commented Nov 14, 2018

No description provided.

@thesmallstar
Copy link
Contributor

I will add them :)

@debck
Copy link
Owner Author

debck commented Jan 13, 2019

@thesmallstar Nice 🎉 . so, which functionality do you want to add?

@thesmallstar
Copy link
Contributor

@debck
I will try to add:

  1. Delete option.
  2. Rename option.
  3. File size option
    Anything you would suggest?

@debck
Copy link
Owner Author

debck commented Jan 13, 2019

That would be great. 👍 You can continue working on that and if u need any help, do reach out

@thesmallstar
Copy link
Contributor

thesmallstar commented Jan 13, 2019 •
edited
Loading

@debck
Update: I have added delete function and it works great.
I wanted to know if I can change the command that starts CLI(create) since the CLI now does more than just creating a file.
Shortly, I would be adding other two features, and adding more feedbacks.
I have not created a separate file for delete function(for now).
You may check the code: https://github.com/thesmallstar/File-Creator-CLI

@debck
Copy link
Owner Author

debck commented Jan 14, 2019 •
edited
Loading

Ya I was thinking of the same . We should change the command .
You can continue with your changes. And make a [wip] PR so that we can track the changes quickly.

@thesmallstar
Copy link
Contributor

thesmallstar commented Jan 14, 2019 •
edited
Loading

I think you would agree on this, to simplify commands I was thinking to keep the main d/f commands same and only add one new command "m" (more) that gives access to other options like delete/size/rename.

@debck
Copy link
Owner Author

debck commented Jan 14, 2019

Ya that would also be nice. 👍

@thesmallstar
Copy link
Contributor

@debck
update: Rename file,filesize option is added.
I will now clean the code up and separate logics.
I find that typing name and then an extension for a file is really annoying, when repeated I think we can take input simply as filename.extension what do you think of this?

@debck
Copy link
Owner Author

debck commented Jan 14, 2019

Ok if thats annoying for users then we should remove that. 👍
U can proceed with the change

@thesmallstar
Copy link
Contributor

Please note the updates, I have separated the codes. Also, now all inputs are taken as filename.extension and not as separate filename and extension. Feedbacks will be added soon.

I was wondering if it is needed to ask whether it is a file or a directory to be created or used. Since , file will always have a '.' then, we can use a regex to check if it is a file or folder. This will reduce all the commands to half.

Eg: create command will create a file if it follows xyz.abc but be a folder if input is only abc

@debck
Copy link
Owner Author

debck commented Jan 15, 2019 •
edited
Loading

For now, I think let it ask question whether it is a file or a directory to be created. 👍 We can change it later if that become little frustrating.

@thesmallstar
Copy link
Contributor

Can you tell me about testing and how should I do it? I am new to this. Haven't done it before.

@debck
Copy link
Owner Author

debck commented Jan 15, 2019 •
edited
Loading

Hey @thesmallstar . To run test execute npm run test in the root of the project. You can see the details whether the test fails or passes. We have used jest to test our application.
If you have any specific question they ping me in slack

thesmallstar pushed a commit to thesmallstar/File-Creator-CLI that referenced this issue Jan 17, 2019
@debck @thesmallstar
# This is a combination of 22 commits.
95bb787 
# This is the 1st commit message:

Update README.md
# This is the commit message debck#2:

Added create folder option, fixes (debck#8) (debck#13)

* Added create folder option, fixes (debck#8)

* Reverted changes to json files to try to not break build

* Better add folder option, fixes (debck#8)

# This is the commit message debck#3:

Update .travis.yml
# This is the commit message debck#4:

Update README.md
# This is the commit message debck#5:

Update app.js

# This is the commit message debck#6:

Update ifdir.js

# This is the commit message debck#7:

Update question.js

# This is the commit message debck#8:

Update ifdir.js

# This is the commit message debck#9:

Update app.js

# This is the commit message debck#10:

Update question.js

# This is the commit message debck#11:

Update app.js

# This is the commit message debck#12:

Update question.js
# This is the commit message debck#13:

Update app.js

# This is the commit message debck#14:

Create functions.js

# This is the commit message debck#15:

Update question.js

# This is the commit message debck#16:

Update ifdir.js

# This is the commit message debck#17:

Update create.js

# This is the commit message debck#18:

Update app.js

# This is the commit message debck#19:

Update create.js

# This is the commit message debck#20:

Create sub.js

# This is the commit message debck#21:

Solves debck#12(Added badges to Readme) (debck#16)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

# This is the commit message debck#22:

Update README.md
@thesmallstar thesmallstar mentioned this issue Jan 17, 2019
Merged
@debck debck closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Expert: 50 points Intermediate open OpenCode19
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@debck @thesmallstar