Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves #12(Added badges to Readme) #16

Merged
merged 4 commits into from Jan 14, 2019
Merged

Solves #12(Added badges to Readme) #16

merged 4 commits into from Jan 14, 2019

Conversation

Archies11
Copy link
Contributor

I have added some badges.

debck
debck requested changes Jan 14, 2019
View reviewed changes
README.md Outdated
@@ -4,6 +4,15 @@

> Made with :heart: for Windows 💻 users, who cannot use `touch` command to create files :+1:

## Badges
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed. Just delete it.

@debck
Copy link
Owner

debck commented Jan 14, 2019 •
edited

You can use https://shields.io/#/ or https://forthebadge.com/ for creating the badges.
And try to add all the badge in the one line. It looks good .
👍

@Archies11
Copy link
Contributor Author

Archies11 commented Jan 14, 2019 •
edited

I will make the changes .Should I change the style of the badges too?

@debck
Copy link
Owner

debck commented Jan 14, 2019

No need. Just add those.

@Archies11
Copy link
Contributor Author

I have made the changes.

@debck
Copy link
Owner

debck commented Jan 14, 2019

Thats good. I answered your question in slack . Can you please see it and add required badges too

@Archies11
Copy link
Contributor Author

I have added some more badges.

debck
debck reviewed Jan 14, 2019
View reviewed changes
README.md Outdated
@@ -4,6 +4,15 @@

> Made with :heart: for Windows 💻 users, who cannot use `touch` command to create files :+1:

<!--Remove the ones not wanted-->
[![Inline docs](http://inch-ci.org/github/Archies11/File-Creator-CLI.svg?branch=master)](http://inch-ci.org/github/Archies11/File-Creator-CLI)
![Dependancy Status](https://david-dm.org/%7B%7Busername%7D%7D/%7B%7Bproject_name%7D%7D.svg)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this URL to Dependency status: https://david-dm.org/debck/File-Creator-CLI.svg

README.md Outdated
[![Inline docs](http://inch-ci.org/github/Archies11/File-Creator-CLI.svg?branch=master)](http://inch-ci.org/github/Archies11/File-Creator-CLI)
![Dependancy Status](https://david-dm.org/%7B%7Busername%7D%7D/%7B%7Bproject_name%7D%7D.svg)
![Build Status](https://ci.appveyor.com/api/projects/status/%7B%7Bstatus_id%7D%7D)
![NPM Version](https://img.shields.io/npm/v/:packageName.svg)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this URL for NPM version : https://badge.fury.io/js/filecreator-cli.svg

README.md Outdated
![Dependancy Status](https://david-dm.org/%7B%7Busername%7D%7D/%7B%7Bproject_name%7D%7D.svg)
![Build Status](https://ci.appveyor.com/api/projects/status/%7B%7Bstatus_id%7D%7D)
![NPM Version](https://img.shields.io/npm/v/:packageName.svg)
![MIT License](https://img.shields.io/npm/l/:packageName.svg?registry_uri=https%3A%2F%2Fregistry.npmjs.com)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this URl to MIT Licence: https://img.shields.io/github/license/debck/File-Creator-CLI.svg?style=flat-square

@debck
Copy link
Owner

debck commented Jan 14, 2019

And Delete the badge for Inline docs and Build status

@Archies11
Copy link
Contributor Author

I have made the required changes.

@debck
Copy link
Owner

debck commented Jan 14, 2019

Now it fine. I will add the Codacy status link later.

@debck debck merged commit 8b7db24 into debck:master Jan 14, 2019
@debck
Copy link
Owner

debck commented Jan 14, 2019 •
edited

@Archies11 always remember to mention the issue no. in the PR as : Fixes #<issue number> Its a good practice and try to make PR form a new branch other than master.

@Archies11
Copy link
Contributor Author

Ok, I will surely keep that in mind. Thank you

thesmallstar pushed a commit to thesmallstar/File-Creator-CLI that referenced this pull request Jan 17, 2019
@debck @thesmallstar
# This is a combination of 22 commits.
95bb787 
# This is the 1st commit message:

Update README.md
# This is the commit message debck#2:

Added create folder option, fixes (debck#8) (debck#13)

* Added create folder option, fixes (debck#8)

* Reverted changes to json files to try to not break build

* Better add folder option, fixes (debck#8)

# This is the commit message debck#3:

Update .travis.yml
# This is the commit message debck#4:

Update README.md
# This is the commit message debck#5:

Update app.js

# This is the commit message debck#6:

Update ifdir.js

# This is the commit message debck#7:

Update question.js

# This is the commit message debck#8:

Update ifdir.js

# This is the commit message debck#9:

Update app.js

# This is the commit message debck#10:

Update question.js

# This is the commit message debck#11:

Update app.js

# This is the commit message debck#12:

Update question.js
# This is the commit message debck#13:

Update app.js

# This is the commit message debck#14:

Create functions.js

# This is the commit message debck#15:

Update question.js

# This is the commit message debck#16:

Update ifdir.js

# This is the commit message debck#17:

Update create.js

# This is the commit message debck#18:

Update app.js

# This is the commit message debck#19:

Update create.js

# This is the commit message debck#20:

Create sub.js

# This is the commit message debck#21:

Solves debck#12(Added badges to Readme) (debck#16)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

# This is the commit message debck#22:

Update README.md
thesmallstar pushed a commit to thesmallstar/File-Creator-CLI that referenced this pull request Jan 20, 2019
@debck @thesmallstar
# This is a combination of 6 commits.
c2ef614 
# This is the 1st commit message:

Update README.md
# This is the commit message debck#2:

Solves debck#12(Added badges to Readme) (debck#16)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

# This is the commit message debck#3:

Update README.md
# This is the commit message debck#4:

Added test cases (debck#14)

* Added create folder option, fixes (debck#8)

* Reverted changes to json files to try to not break build

* Better add folder option, fixes (debck#8)

* Added test cases and fixed build, fixes (debck#7) and tries to fix (debck#11)

* Revert "Added test cases and fixed build, fixes (debck#7) and tries to fix (debck#11)"

This reverts commit 54b8bb4.

* Added test cases, fixes (debck#7) and possibly, (debck#11)

* Cleanup for fixes (debck#7) and (debck#11)

* Deleted unwanted file for fixes (debck#7) and (debck#11)

* Resolved 2 merge conflicts, for fixes (debck#7) and (debck#11)

* Attempting to fix Travis CI build, fixing (debck#11)

* Trying to fix TravisCI build, (debck#11)

* Yet another attempt to fix (debck#11)

* More cleanup for fixing (debck#7) and (debck#11)

* Final fix for (debck#7) and (debck#11), added statement to exit upon completion

* Final-final commit for fixing (debck#7) and (debck#11)

* Final-final-final commit for fixing (debck#7) and (debck#11), added missing file

# This is the commit message debck#5:

(Final PR - Added Functions) (debck#15)


# This is the commit message debck#6:

(Final PR - Added Functions) (debck#15)

(Final PR - Added Functions)

Update sub.js

Update functions.js
thesmallstar added a commit to thesmallstar/File-Creator-CLI that referenced this pull request Jan 20, 2019
@thesmallstar
# This is a combination of 8 commits.
ac59eae 
# This is the 1st commit message:

Update README.md
# This is the commit message debck#2:

Solves debck#12(Added badges to Readme) (debck#16)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

# This is the commit message debck#3:

Update README.md
# This is the commit message debck#4:

Added test cases (debck#14)

* Added create folder option, fixes (debck#8)

* Reverted changes to json files to try to not break build

* Better add folder option, fixes (debck#8)

* Added test cases and fixed build, fixes (debck#7) and tries to fix (debck#11)

* Revert "Added test cases and fixed build, fixes (debck#7) and tries to fix (debck#11)"

This reverts commit 54b8bb4.

* Added test cases, fixes (debck#7) and possibly, (debck#11)

* Cleanup for fixes (debck#7) and (debck#11)

* Deleted unwanted file for fixes (debck#7) and (debck#11)

* Resolved 2 merge conflicts, for fixes (debck#7) and (debck#11)

* Attempting to fix Travis CI build, fixing (debck#11)

* Trying to fix TravisCI build, (debck#11)

* Yet another attempt to fix (debck#11)

* More cleanup for fixing (debck#7) and (debck#11)

* Final fix for (debck#7) and (debck#11), added statement to exit upon completion

* Final-final commit for fixing (debck#7) and (debck#11)

* Final-final-final commit for fixing (debck#7) and (debck#11), added missing file

# This is the commit message debck#5:

(Final PR - Added Functions) (debck#15)


# This is the commit message debck#6:

(Final PR - Added Functions) (debck#15)

(Final PR - Added Functions)

Update sub.js

Update functions.js

# This is the commit message debck#7:

(Final PR - Added Functions)

# This is the commit message debck#8:

Update sub.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debck debck debck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Archies11 @debck