Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-1570 handle null toasted values for wal2json #1123

Merged
merged 1 commit into from
Nov 8, 2019
Merged

DBZ-1570 handle null toasted values for wal2json #1123

merged 1 commit into from
Nov 8, 2019

Conversation

jpechane
Copy link
Contributor

@jpechane jpechane commented Nov 7, 2019

gunnarmorling
gunnarmorling approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, applying. Thanks, @jpechane!

...nnector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
@@ -462,6 +482,10 @@ public boolean hasUnchangedToastColumnMarker() {
return true;
}

public boolean sendsNullToastedValuesInOld() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, seeing the need for this method makes my eyes bleed... Could you also create an issue with wal2json, it seems it should be fixed there ideally?

@gunnarmorling gunnarmorling merged commit d693609 into debezium:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarmorling gunnarmorling gunnarmorling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpechane @gunnarmorling