DBZ-1857 Support for autorestart for embedded engine #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarmorling
requested changes
Mar 20, 2020
| @FixFor("DBZ-1857") | ||
| // The column used to kill connection is only supported since Postgres version 10 | ||
| @SkipWhenDatabaseVersionLessThan(POSTGRES_10) | ||
| public void shouldRecoverFromRetriableException() throws Exception { |
...m-connector-postgres/src/test/java/io/debezium/connector/postgresql/PostgresConnectorIT.java
Show resolved
Hide resolved
debezium-core/src/main/java/io/debezium/connector/common/BaseSourceTask.java
Show resolved
Hide resolved
jpechane
force-pushed
the
DBZ-1857
branch
3 times, most recently
from
ec5e07f
to
520ec71
Compare
| // WorkerSourceTask calls us immediately after we return the empty list. | ||
| // This turns into a throttling so we need to make a pause before we return | ||
| // the control back. | ||
| Thread.sleep(PAUSE_WHEN_NOT_STARTED); |
There was a problem hiding this comment.
Should be Metronome#parker().
debezium-embedded/src/main/java/io/debezium/embedded/EmbeddedEngine.java
Show resolved
Hide resolved
gunnarmorling
approved these changes
Mar 23, 2020
|
Rebased and applied. Thanks, @jpechane. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-1857