Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-3499 Add support for parsing of newer MySQL privileges #2342

Merged
merged 2 commits into from
May 6, 2021

Conversation

tommyk-gears
Copy link
Contributor

Added the privileges listed at https://dev.mysql.com/doc/refman/8.0/en/privileges-provided.html to the MySQL parser (note that Table 6.3 on that page is incomplete, there are privileges not listed in that table but documented further down in the document, e.g. SERVICE_CONNECTION_ADMIN)

@jpechane
Copy link
Contributor

jpechane commented May 5, 2021

@tommyk-gears Hi, thanks for the PR, it looks good!
I'd just propose one change, I'd recommend to add the test statements into debezium-ddl-parser/src/test/resources/mysql/examples/grant.sql instead of the Java code.
When done could you please also prepare a PR to the upstream grammar - https://github.com/antlr/grammars-v4/tree/master/sql/mysql/Positive-Technologies
With the example statements moved to the SQL file you'd be able to prepare it with almost no problem.

@jpechane
Copy link
Contributor

jpechane commented May 6, 2021

@tommyk-gears I am doing a release today so I took a liberty and did the changes, could you please still prepare the usptream PR and link it here?

@jpechane jpechane merged commit b4327ab into debezium:master May 6, 2021
@tommyk-gears
Copy link
Contributor Author

@jpechane Thanks for quick feedback and for fixing my messy test case!
I created the upstream PR here: antlr/grammars-v4#2184

@jpechane
Copy link
Contributor

jpechane commented May 6, 2021

@tommyk-gears Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants