Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-3953 Mark wal2json plugin as deprecated #3146

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

jpechane
Copy link
Contributor

Copy link
Member

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall; a few minor remarks/suggestions inline.

See the documentation for your chosen plug-in to learn more about the plug-in's requirements, limitations, and how to compile it.
The PostgreSQL connector works with one of {prodname}'s supported logical decoding plug-ins to encode the changes in either link:https://github.com/google/protobuf[Protobuf format] or link:https://github.com/postgres/postgres/blob/master/src/backend/replication/pgoutput/pgoutput.c[pgoutput] format.
`pgoutput` plugin comes out-of-the-box with PostgreSQL server.
For other plug-in see the documentation for your chosen plug-in to learn more about the plug-in's requirements, limitations, and how to compile it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds a bit odd, given that the "other plug-in" is maintained by ourselves.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gunnarmorling Rephrased

Copy link
Member

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, going to amend this with some more tweaks and will merge. Please take a look at them and let me know if you see any issues with them. Thx!

@gunnarmorling gunnarmorling merged commit c5c3754 into debezium:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants