Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-4654 Oracle DDL parser failure & relax SnapshotType case sensitivity #3183

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

Naros
Copy link
Member

@Naros Naros commented Feb 2, 2022

@Naros Naros added 1.8 labels Feb 2, 2022
@Naros Naros changed the title DBZ-4654 Support name based log groups DBZ-4654 Oracle DDL parser failure & relax SnapshotType case sensitivity Feb 2, 2022
@gunnarmorling
Copy link
Member

@Naros, in the commit message, could you reference https://issues.redhat.com/browse/DBZ-4648 for the casing issue? It got reported there two. And then update the title of DBZ-4654 to be focussed on the parsing issue. Thx!

@Naros
Copy link
Member Author

Naros commented Feb 3, 2022

Updated the case-sensitivity commit message issue key to DBZ-4648 & the Jira issue title for DBZ-4654.

Edit: I feel the test failures are unrelated as the tests originally passed and the only change I did with the PR was the reword of one commit and the squashing of the former 2 last commits into 1 since they were related to the same task.

@gunnarmorling
Copy link
Member

Thx for splitting this up, this LGTM now. Agreed re the test failure, seems like a network glitch maybe. No need to react to it right now IMO. Will merge.

@gunnarmorling gunnarmorling merged commit 3980210 into debezium:main Feb 3, 2022
@gunnarmorling
Copy link
Member

Applied to main (1.9) and 1.8.

@gunnarmorling
Copy link
Member

@Naros, doh, sorry, realizing now I've merged that to upstream/1.8 instead of the candidate branch :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants