Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7508 Exit from readChunk after createDataEventsForTable if snapshot is not running anymore #5301

Merged
merged 1 commit into from Feb 22, 2024

Conversation

mfvitale
Copy link
Member

@mfvitale
Copy link
Member Author

Postgres test failures is not related. Fixed with #5303

@mfvitale
Copy link
Member Author

All DB2 test are already marked as flaky but dunno why is still reported. @Naros Any idea?

@jpechane
Copy link
Contributor

It seems that the workflow in core do not have flag -Dfail.flaky.tests=false set.

Also I completely forgot, the default value for Flaky test reattempt is just 1. Maybe we should change it?

@mfvitale
Copy link
Member Author

It seems that the workflow in core do not have flag -Dfail.flaky.tests=false set.

Should the flag logic inverted, so that we force it to fail only on specific pipes?

Also I completely forgot, the default value for Flaky test reattempt is just 1. Maybe we should change it?

What is the meaning of "reattempt" here? Does it means that when flaky test is ran then it will execute x times?

@jpechane
Copy link
Contributor

@mfvitale Yes, please see io.debezium.junit.ConditionalFail.ignoreFlakyFailure(Statement, Description, Flaky)

@mfvitale mfvitale requested a review from Naros February 22, 2024 08:46
@rk3rn3r
Copy link
Member

rk3rn3r commented Feb 22, 2024

Thx @mfvitale for the PR. I just hit the same error and found 3 issues (one of those is this DBZ-7508) in Jira and linked them and closed the duplicate. Thx for the fix.

Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfvitale.

@Naros Naros merged commit 08e4681 into debezium:main Feb 22, 2024
34 of 38 checks passed
@Naros
Copy link
Member

Naros commented Feb 22, 2024

Applied to main (=2.6).

@mfvitale mfvitale deleted the DBZ-7508 branch February 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants