Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-7508 Exit from readChunk after createDataEventsForTable if snapshot is not running anymore #5301

Merged
merged 1 commit into from
Feb 22, 2024
Merged

DBZ-7508 Exit from readChunk after createDataEventsForTable if snapshot is not running anymore #5301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion ...nector-mysql/src/test/java/io/debezium/connector/mysql/ReadOnlyIncrementalSnapshotIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,6 @@ public void testStopSnapshotKafkaSignal() throws Exception {
return logInterceptor.containsMessage(tableRemoveMessage);
});

stopConnector();
}

@Test
Expand Down
5 changes: 5 additions & 0 deletions ...um/pipeline/source/snapshot/incremental/AbstractIncrementalSnapshotChangeEventSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,13 @@ protected void readChunk(P partition, OffsetContext offsetContext) throws Interr
context.maximumKey().orElse(new Object[0]));
}
}

if (createDataEventsForTable(partition)) {

if (!context.snapshotRunning()) { // A stop signal has been processed and window cleared.
return;
}

if (window.isEmpty()) {
LOGGER.info("No data returned by the query, incremental snapshotting of table '{}' finished",
currentTableId);
Expand Down