Add verification for downloads of update.sh #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, during the build process, packages were downloaded over http without authentication. Now, the Release file and packages are properly verified. If verification fails, a warning will be presented to the user with the option to ignore it. Note that in order to perform GPG verification of the Release file, the user must have the Raspbian signing key in their keyring. The key can be obtained from public keyservers (0x9165938D90FDDD2E) or from https://archive.raspbian.org/raspbian.public.key.
|
Nice! I'll review it ASAP. |
|
Please see #66 instead, which is a superset of this pull request. |
hoehnp
pushed a commit
to hoehnp/raspbian-ua-netinst
that referenced
this pull request
Jul 14, 2019
hoehnp
pushed a commit
to hoehnp/raspbian-ua-netinst
that referenced
this pull request
Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, during the build process, packages were downloaded over http
without authentication. Now, the Release file and packages are properly
verified. If verification fails, a warning will be presented to the
user with the option to ignore it.
Note that in order to perform GPG verification of the Release file, the
user must have the Raspbian signing key in their keyring. The key can
be obtained from public keyservers (0x9165938D90FDDD2E) or from
https://archive.raspbian.org/raspbian.public.key.
Edit: I added another commit to use the Release file to check the available compression formats instead of using
wget --spider. These two commits should resolve #55.Note that I made the assumption that the last checksums in the Release file are SHA256 sums, which is true now but may change in the future.