Skip to content

Commit

Permalink
Revert "[pki] Fix missing quotes causing invalid directory creation"
Browse files Browse the repository at this point in the history
This reverts commit 631dadf.

I've gotten reports that this patch causes issues with retrieving X.509
certificates from Let's Encrypt CA via ACME. I'm not sure what's causing
this, but reverting the change fixes this issue.
  • Loading branch information
drybjed committed Apr 12, 2023
1 parent 848aaed commit 5a06243
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,6 @@ General
correctly. After that re-run the :ref:`debops.pki` role on the host to
re-create che realms.

- Path of the Root CA directory on the Ansible Controller is quoted in the
:file:`pki-authority` script to prevent wrong directory creation.

:ref:`debops.preseed` role
''''''''''''''''''''''''''

Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/pki/files/secret/pki/lib/pki-authority
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ initialize_environment () {
config["private_file_mode"]="600"

# shellcheck disable=SC2174
test -d "${config['pki_root']}" || mkdir -p -m ${config['public_dir_mode']} "${config['pki_root']}"
test -d ${config['pki_root']} || mkdir -p -m ${config['public_dir_mode']} ${config['pki_root']}
}

enter_authority () {
Expand Down

0 comments on commit 5a06243

Please sign in to comment.