3762 popup editor #4151
Merged
3762 popup editor #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helenayele - could you check to see if i've missed out any Outline types that don't provide a popup editor? |
helenayele
requested changes
May 10, 2019
There was a problem hiding this comment.
Now I am able to see the popup window ,
But editing its property and approving throws NPE.
NPE_While_approving_changes.txt
|
@helenayele - hopefully fixed |
|
And also I tried to check by opening most of the rep and dpf file from sample_data and I get all items's property window opened. |
|
Yes , now able to approve my changes without any issue. But after approving my changes when I select reset it logs exception but this is filed as separate issue on #4150 |
helenayele
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3762