Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: document debug instance destroy() method #738

Closed
wants to merge 1 commit into from
Closed

README: document debug instance destroy() method #738

wants to merge 1 commit into from

Conversation

ibc
Copy link
Contributor

@ibc ibc commented Jan 12, 2020

Related to #678, this PR adds a new section "Destroying a debug instance" in the README explaining that dynamically created debug instances must be destroyed in order to avoid a memory leak.

It also does a minor/cosmetic cleanup in the README file.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.692% when pulling 36c24c4 on ibc:master into 3f4d724 on visionmedia:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.692% when pulling 36c24c4 on ibc:master into 3f4d724 on visionmedia:master.

@Qix-
Copy link
Member

Qix- commented Jan 12, 2020

No thanks. #678 is a bug. The readme shouldn't document how to workaround bugs.

@Qix- Qix- closed this Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants