-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax pyparsing requirement. #812
Conversation
If I remember well, the requirement to keep pyparsing 2.x is due to ViperMonkey, which does not work with pyparsing 3 (and requires oletools). |
I see that specific constraint for ViperMonkey here https://github.com/decalage2/ViperMonkey/blob/master/requirements.txt#L6 The vipermonkey tests don't currently run python 3 so I haven't explored if any tests fail on pyparsing 3.x yet. |
We are also getting version conflicts in odoo. We need a version that supports pyparsing>3 |
I've added a PR decalage2/ViperMonkey#125 to ViperMonkey. @decalage2 I think this project should move on, if it is working with newer pyparsing versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hit by the same issue on Odoo.sh
@vEpiphyte |
@gbtechnology I am not a maintainer on this project. I cannot merge it. |
@decalage2 will you also release a new version so this change gets available via pip? |
Seconding this, would be a huge help. |
All oletools unit tests pass with pyparsing 3.0.9 installed.
This makes it easier to use oletools as a library.