Field unique id branch #1087
Merged
Field unique id branch #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for netlify-cms-www ready! Built with commit 35b21b3 |
|
Deploy preview for cms-demo ready! Built with commit 35b21b3 |
|
This is great @xifengjin88, thanks! Mind adding yourself to the all contributors list? Instructions here: https://github.com/netlify/netlify-cms/blob/master/CONTRIBUTING.md#add-yourself-as-a-contributor |
|
@erquhart Just added myself as a contributor. thanks for your help. |
erquhart
approved these changes
Feb 8, 2018
|
@erquhart Hi, just want to make sure this PR is successfully approved. I still see some conflicts. |
|
Fixed, will merge in a sec. |
This was referenced Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Closes issue #423
Current PR fixes a11y issues by adding a unique ID to form fields
- Test plan
Tested locally, as I type into the input field, label, and its corresponding input field all have the same unique id
- Description for the changelog
added a unique id to the input field and its label
- A picture of a cute animal (not mandatory but encouraged)