Fix regression in list relation previews #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Deploy preview for netlify-cms-www ready! Built with commit d6aded6 |
|
Deploy preview for cms-demo ready! Built with commit d6aded6 |
erquhart
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Closes #1198 - regression fix: PR #1087 broke relation lists preview.
- Test plan
This is hard, I haven't found any example in the demo that shows this. The ListControl component was using the
forIDproperty to check for metadata that has a structure likebut the changes to ensure
forIDuniqueness breaks this of course as the metadata doesn't have that unique string in the object's property names.This fix ensures that ListControl uses the collection name without any unique string attached when checking for metadata.
- Description for the changelog
(Fix regression) previews for relation lists broken by #1087