Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: migrate Beta Features - List Widget: Variable Types #7053

Conversation

privatemaker
Copy link
Contributor

Relating to #7040

@privatemaker privatemaker requested a review from a team as a code owner January 23, 2024 00:13
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for decap-www ready!

Name Link
🔨 Latest commit cc5e107
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/65b774a687b1d100080ea64f
😎 Deploy Preview https://deploy-preview-7053--decap-www.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@martinjagodic martinjagodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is not it's own widget, so I have a dilemma about where to place these instructions. Especially because #7031 aims to add this support to objects as well. If we choose this idea (separate file), we have to at least link to it from the list widget doc.

@mmkal sice you are working on variable objects, could you provide some feedback as well?

@privatemaker
Copy link
Contributor Author

Thank you for the details

...we have to at least link to it from the list widget doc.

I was not aware that was under development. Neat 😎 My instinct is that the best way is then to make it an individual page in the group: Fields this way it is:

  • Discreet from all the other field widgets
  • Is a more advanced configuration step
  • Can be expanded with examples of the list widget without being too long

I pushed this proposal @martinjagodic @mmkal

@martinjagodic
Copy link
Member

This is better, thanks!

@privatemaker privatemaker force-pushed the docs/beta-features/widget-variable-types branch from 5ba7b57 to cc5e107 Compare January 29, 2024 09:49
@martinjagodic martinjagodic merged commit 2f4540d into decaporg:master Jan 29, 2024
16 checks passed
@privatemaker privatemaker deleted the docs/beta-features/widget-variable-types branch February 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants