Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs: migrate Beta Features - Custom Mount Element #7059

Merged

Conversation

privatemaker
Copy link
Contributor

Given how minimal this is, it feels wrong it is on own page, but it seems semantically to make most sense.

I am not sure in what creative cases this is useful or what code to do it looks like- maybe because I am not a React developer? 🤔

@martinjagodic perhaps adding some example snippets and slightly more text or links to examples?

Relating to #7040

@privatemaker privatemaker requested a review from a team as a code owner January 23, 2024 10:00
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for decap-www ready!

Name Link
🔨 Latest commit 948ded8
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/65afbab5f2aafc00086b8f3b
😎 Deploy Preview https://deploy-preview-7059--decap-www.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@martinjagodic
Copy link
Member

I agree, this should be better documented. Let me take some time for this and get back with some snippets.

@martinjagodic martinjagodic self-assigned this Jan 23, 2024
@martinjagodic
Copy link
Member

It is pretty easy: Just add id="nc-root" to any element, and the CMS will load into it. It is useful if you want to create a wrapper around the CMS, like a custom header or footer.

My suggestion for the docs:


For example, adding this div to admin/index.html will cause the CMS to load within it:

<div id="nc-root"></div>

@martinjagodic martinjagodic removed their assignment Jan 23, 2024
@privatemaker
Copy link
Contributor Author

Super. Thank you for clarifying. I incorporated that into the page 😄

@martinjagodic martinjagodic enabled auto-merge (squash) January 23, 2024 13:10
@martinjagodic martinjagodic merged commit 4411cc0 into decaporg:master Jan 23, 2024
15 of 16 checks passed
@privatemaker privatemaker deleted the docs/beta-features/custom-mount branch February 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants