refactor: datetime to support custom date and time formats #7091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjagodic
requested review from
demshy
and removed request for
a team and
demshy
|
@demshy fixtures would have to be recorded as base64 blobs change because default datetime format changed. |
|
In trying to specify the
However, none of those formatting values change the date display from what is described in #7090 It would be good to update the Docs with these two differences of formats once this Day.js feature is fixed. |
martinjagodic
commented
Feb 19, 2024
demshy
approved these changes
Mar 29, 2024
This was referenced Mar 29, 2024
Closed
1 task
1 task
yuri-g-taboola
referenced
this pull request
in taboola/decap-cms
May 22, 2024
* refactor: datetime to support custom date and time formats * refactor: improve date formatting * fix: fix dev test script * test: update fixtures * test: set timezone for ci e2e tests * test: update jest * fix: work in progress on datetime control * fix: date and time formatting, handle picker_utc * fix: remove undefined variable, format * fix: jest-environment-jsdom version * refactor: dayjs imports, getFormat and onInputChange functions * fix: set default value * fix: lint datetime control --------- Co-authored-by: Anze Demsar <anze.demsar@p-m.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the problem with time_format in datetime widget described in #7090
Adds back support for
picker_utcdescribed in #7132