Support ChildWatcher.rstatus #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
support-ChildWatcher.rstatus
branch
from
c1c9ef8
to
eea75cf
Compare
|
depends on #7 |
| # asyncio messes with the status code value, go up the stack and get it | ||
| try: | ||
| outer_frame = sys._getframe(1) | ||
| status = outer_frame.f_locals['status'] |
There was a problem hiding this comment.
status is not always present in upper stack - would better if we can reverse the "mess"
graingert
force-pushed
the
support-ChildWatcher.rstatus
branch
2 times, most recently
from
a08a240
to
fcc3bf8
Compare
graingert
force-pushed
the
support-ChildWatcher.rstatus
branch
from
fcc3bf8
to
de149b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7