feat: improved approval flow #1576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: use label for supply in rarity dropdown * refactor: make modalSaga a generator * refactor: decouple modal logic from item save saga * feat: save published items * fix: wrong this on lambda * chore: configure tests * chore: fix circular dep * chore: added tests for saveItemRequest * chore: added tests for savePublishedItemRequest * chore: use call instead of matchers * ci: commented out coveralls report * ci: uncommented coveralls report
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/decentraland/builder/BcnCdGYds62bBnmhLXEkVpdFKeKx |
* chore: fix eslint typescript errors * chore: import order * feat: show status indicator for collections and items * chore: rename file * chore: added tests * chore: remove thing * chore: added another test * fix: type * refactor: use && instead of ternary Co-authored-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com>
* chore: fix eslint typescript errors * chore: import order * feat: show status indicator for collections and items * refactor: CollectionAction component to simplify CollectionDetailPage * refactor: Remove useMemo * refactor: mergeProps so collectionId does not have to be provided * feat: Add push changes button when collection is dirty * feat: Add push collection changes modal (wip) * feat: Add curation reducer, actions and types * feat: Add curation saga and fetch curations request * feat: Can't push a curation if there is one pending * feat: Push curation * refactor: More readable if structure * chore: Add text * feat: Fetch single curation request * fix: canChangedBePushed and areChangesUnderReview * chore: Update text * chore: Update popup style for under review pushes * feat: Fetch curations when committee member request succeeds * feat: Display collection in curation list that were requested for review * refactor: Update curation type * feat: Show approve button on collections that have curation * feat: Add reject and approve curation actions sagas and reducers * feat: Display buttons in item editor according to the review type * feat: Add disable button to item editor when you want to set available to false * fix: ReviewModal * feat: Don't show approve button on rejected curation * refactor: CollectionAction types + selectors * chore: Add new translations to item_editor in chinese and spanish * chore: Add push_collection_changes_modal translations for es and zh * chore: Add collection_detail_page translations for es and zh * chore: Add collection_row translations for es and zh * chore: Remove unused authorizations from CollectionDetailPage * chore: Rename ExtCollection * feat: Status takes into consideration under review because of curation * fix: selector tests * fix: Fix CollectionItem state * chore: Add curation selectors tests * chore: Add curation reducer tests * chore: Add some curation sagas tests * chore: Add push curation saga tests * refactor: Abstract mock builder * chore: Remove disabled button and update some texts * feat: Show orb on mint items modal * feat: Show dirty item as under review when a curation is ongoing * feat: Show warning when one of the items you are minting has changes to be approved * feat: Show warning when trying to sell a collection with items with pending reviews * fix: Item selectors test * refactor: Move UnderReview component to separate files Co-authored-by: Juan Cazala <juancazala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.