Skip to content

Commit

Permalink
feat: use onClearFilters instead of onBrowse
Browse files Browse the repository at this point in the history
  • Loading branch information
juanmahidalgo committed Oct 16, 2023
1 parent 13b879e commit 1ce7ea8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 13 deletions.
4 changes: 2 additions & 2 deletions webapp/src/components/Navigation/Navigation.container.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { openBuyManaWithFiatModalRequest } from 'decentraland-dapps/dist/modules
import { getIsCampaignBrowserEnabled } from '../../modules/features/selectors'
import { getIsFullscreen } from '../../modules/routing/selectors'
import { RootState } from '../../modules/reducer'
import { browse } from '../../modules/routing/actions'
import { clearFilters } from '../../modules/routing/actions'
import {
MapDispatch,
MapDispatchProps,
Expand All @@ -18,7 +18,7 @@ const mapState = (state: RootState): MapStateProps => ({

const mapDispatch = (dispatch: MapDispatch): MapDispatchProps => ({
onOpenBuyManaWithFiatModal: () => dispatch(openBuyManaWithFiatModalRequest()),
onBrowse: options => dispatch(browse(options))
onClearFilters: () => dispatch(clearFilters())
})

export default connect(mapState, mapDispatch)(Navigation)
9 changes: 2 additions & 7 deletions webapp/src/components/Navigation/Navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const Navigation = (props: Props) => {
isFullscreen,
isCampaignBrowserEnabled,
onOpenBuyManaWithFiatModal,
onBrowse
onClearFilters
} = props
const analytics = getAnalytics()
const isMobile = useMobileMediaQuery()
Expand Down Expand Up @@ -72,12 +72,7 @@ const Navigation = (props: Props) => {
) : null}
<Link
to={locations.browse(browseDefaultOptions)}
onClick={() =>
onBrowse({
...browseDefaultOptions,
search: ''
})
}
onClick={onClearFilters}
>
<Tabs.Tab active={activeTab === NavigationTab.COLLECTIBLES}>
{t('navigation.collectibles')}
Expand Down
8 changes: 4 additions & 4 deletions webapp/src/components/Navigation/Navigation.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
openBuyManaWithFiatModalRequest,
OpenBuyManaWithFiatModalRequestAction
} from 'decentraland-dapps/dist/modules/gateway/actions'
import { browse, BrowseAction } from '../../modules/routing/actions'
import { clearFilters, ClearFiltersAction } from '../../modules/routing/actions'

export enum NavigationTab {
OVERVIEW = 'overview',
Expand All @@ -24,11 +24,11 @@ export type Props = {
onOpenBuyManaWithFiatModal: () => ReturnType<
typeof openBuyManaWithFiatModalRequest
>
onBrowse: typeof browse
onClearFilters: typeof clearFilters
}

export type MapDispatch = Dispatch<
OpenBuyManaWithFiatModalRequestAction | BrowseAction
OpenBuyManaWithFiatModalRequestAction | ClearFiltersAction
>

export type MapStateProps = Pick<
Expand All @@ -37,5 +37,5 @@ export type MapStateProps = Pick<
>
export type MapDispatchProps = Pick<
Props,
'onOpenBuyManaWithFiatModal' | 'onBrowse'
'onOpenBuyManaWithFiatModal' | 'onClearFilters'
>

0 comments on commit 1ce7ea8

Please sign in to comment.