fix: fix bug missing deps in useMemo

decentraland · Jan 24, 2024 · 64e9733 · 64e9733
1 parent 481db7e
commit 64e9733
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.spec.tsx b/webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.spec.tsx
@@ -159,6 +159,18 @@ describe('ClaimNameFatFingerModal', () => {
           expect(onClaimMock).not.toHaveBeenCalledWith(name)
         })
       })
+    })
+    describe('when clicking the claim button', () => {
+      beforeEach(() => {
+        getSignerMock.mockResolvedValueOnce(
+          (signerMock as unknown) as ethers.providers.JsonRpcSigner
+        )
+        ;(DCLController__factory.connect as jest.Mock).mockResolvedValueOnce({
+          interface: {
+            encodeFunctionData: jest.fn()
+          }
+        })
+      })
       it('should open FIAT gateway widget when claim button is clicked', async () => {
         const { getByRole, getByText } = renderWithProviders(
           <ClaimNameFatFingerModal

diff --git a/webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.tsx b/webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.tsx
@@ -149,7 +149,10 @@ const ClaimNameFatFingerModal = ({
     }
   }, [wallet, ENSName, analytics, onOpenFiatGateway, onClaimTxSubmitted])
 
-  const isLoading = useMemo(() => isClaiming || isLoadingFIATWidget, [])
+  const isLoading = useMemo(() => isClaiming || isLoadingFIATWidget, [
+    isClaiming,
+    isLoadingFIATWidget
+  ])
 
   const handleClaimWithCardClick = useCallback(() => {
     return isClaimingNamesWithFiatEnabled && !isLoading