fix: wait for identity success action before fetching catalog #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzavalia
approved these changes
Aug 15, 2023
juanmahidalgo
merged commit 8392277
into
feat/marketplace-server-catalog
4 of 6 checks passed
juanmahidalgo
added a commit
that referenced
this pull request
Sep 7, 2023
juanmahidalgo
added a commit
that referenced
this pull request
Sep 21, 2023
juanmahidalgo
added a commit
that referenced
this pull request
Sep 22, 2023
juanmahidalgo
added a commit
that referenced
this pull request
Oct 16, 2023
juanmahidalgo
added a commit
that referenced
this pull request
Nov 8, 2023
…1967) * feat: introduce logic to fetch catalog from the marketplace-server * feat: use correct URL for the marketplace server * feat: wait for FFs to be loaded * fix: card overflow is clickeable * test: fix broken tests * feat: add generator getCatalogAPI to abstract the API selection logic * chore: remove unwanted comment * fix: wait for identity success action before fetching catalog (#1974) * feat: remove old import * test: fix broken test * chore: reset dev.json values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getIdentityfn is not sync, so it can happen that the Fetch Items Request is triggered before getting the identity, so it gets triggered without being signed.