fix: Estate fingerprint calculation #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meelrossi
force-pushed
the
fix/fingerprint-calculation
branch
from
9da3715
to
045299b
Compare
meelrossi
changed the title
fzavalia
reviewed
Nov 8, 2023
| @@ -17,6 +17,7 @@ import { VendorName } from '../../modules/vendor' | |||
| import { NFT } from '../../modules/nft/types' | |||
| import Popup from './Popup' | |||
| import './Atlas.css' | |||
| import ErrorBanner from '../ErrorBanner' | |||
| @@ -28,6 +28,7 @@ import { ConfirmInputValueModal } from '../../ConfirmInputValueModal' | |||
| import { Mana } from '../../Mana' | |||
| import { Props } from './BidModal.types' | |||
| import './BidModal.css' | |||
| import ErrorBanner from '../../ErrorBanner' | |||
| @@ -33,6 +33,7 @@ import { PartiallySupportedNetworkCard } from '../PartiallySupportedNetworkCard' | |||
| import { NotEnoughMana } from '../NotEnoughMana' | |||
| import { PriceHasChanged } from '../PriceHasChanged' | |||
| import { Props } from './BuyNFTModal.types' | |||
| import ErrorBanner from '../../ErrorBanner' | |||
|
|
||
| for (const parcel of parcels) { | ||
| estateTokenIds.push( | ||
| (await contract.encodeTokenId(parcel.x, parcel.y)).toString() |
There was a problem hiding this comment.
Is this toString necessary?
The land tokenId is then used in ethers.utils.solidityKeccak256 so I believe that big number should be handled without the need of stringifying.
|
Should the message cover the 100% of the width? 
|
fzavalia
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently having a cache problem causing the information coming from the atlas-server to be outdated. For this, in several parts of the ui (atlas, estate detaill, etc) we are showing information that is not up to date misleading the user to what they are actually seeing/buying.
To solve some of the consequences of this, this PR adds:
Fingerprint calculation for estates in the ui and compare it with the one generated with the contract. If this fingerprints are not the same then the information is not up to date and we prevent the user from buying the land/estate.
Add warning messages in the atlas and in the buy and bid page to make the users aware of the missmatch