fix: Don't set ens filter to on sale by default on the current accoun… #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fzavalia
commented
Feb 14, 2024
Comment on lines
33
to
41
| const EmotesFilters = [ | ||
| ...WearablesFilters.filter( | ||
| filter => | ||
| filter !== AssetFilter.BodyShape && | ||
| filter !== AssetFilter.Network && | ||
| filter !== AssetFilter.More && | ||
| filter !== AssetFilter.OnlySmart | ||
| ), | ||
| AssetFilter.Rarity, | ||
| AssetFilter.Status, | ||
| AssetFilter.Price, | ||
| AssetFilter.Collection, | ||
| AssetFilter.Creators, | ||
| AssetFilter.OnSale, | ||
| AssetFilter.More, | ||
| AssetFilter.PlayMode |
There was a problem hiding this comment.
Added the more filter so it shows the on sale filter on my account for emotes.
Removed the .filter and copied the required filters for emotes to prevent the case in which new filters are added to the wearable filters and we forget to remove it from the emote filters.
fzavalia
commented
Feb 14, 2024
Comment on lines
+702
to
706
| // Only if the user is not in their own page, show ens on sale by default. | ||
| if (window.location.pathname !== locations.currentAccount()) { | ||
| newOptions.onlyOnSale = | ||
| previous.onlyOnSale === undefined ? true : current.onlyOnSale | ||
| } |
There was a problem hiding this comment.
What was happening is that on your own account page, it was being set to only on sale, which then forced the only on sale on the other tabs.
cyaiox
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t page
Closes #2129