fix: Various mint name with crypto fixes #2145
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| export type Props = ButtonProps & { | ||
| assetNetwork: Network | ||
| } | ||
| export type Props = ButtonProps |
There was a problem hiding this comment.
can we add EOF here?
|
|
||
| const onCloseModal = useCallback(() => { | ||
| onCloseFatFingerModal() | ||
| return onClose() |
There was a problem hiding this comment.
| return onClose() | |
| onClose() |
just to keep it consistent with the one above
There was a problem hiding this comment.
As we're replacing the onClose method from the original one to this one, the BuyWithCryptoModal expects the type of the method to return the same type as the original onClose. I could either keep the return there or change the type in the BuyWithCryptoModal what do you find best?
| {formatPrice(Number(gasCost.total), gasCost.token)} | ||
| <span> + </span> | ||
| </> | ||
| ) : null} | ||
| <img src={selectedToken?.logoURI} alt={selectedToken?.name} /> | ||
| <Popup |
There was a problem hiding this comment.
Just a thought... it would be nice to abstract this in a component (or even just a function) that recieves the token and returns the wrapped one. (to avoid repetetition of the props on, position, style, etc, that are all the same in this cases)
There was a problem hiding this comment.
Done! Created the TokenIcon component.
This PR fixes the following:
BuyWithCryptoButtonto be set as Matic so the white logo is shown. The red logo was fusing with the red color of the button, preventing it from being seen.ChainButtonwhen buying with card to be just a simple button.FatFingermodal when closing theBuyWithCryptoModalmodal when paying for the minting of a name.InfoTooltipthat talked about paying the gas fee with the native token to remove the need to name all native tokens.