fix: select the first token from the chain selected #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
juanmahidalgo
commented
Feb 27, 2024
| @@ -225,7 +225,10 @@ export const BuyWithCryptoModal = (props: Props) => { | |||
| manaTokenOnSelectedChain || getMANAToken(selectedChain) | |||
| ) // if it's not in the providerTokens, create the object manually with the right conectract address | |||
| } catch (error) { | |||
| setSelectedToken(providerTokens[0]) | |||
| const selectedChainTokens = providerTokens.filter( | |||
There was a problem hiding this comment.
pick the first token from the selected chain, otherwise it can belong to other one
juanmahidalgo
commented
Feb 27, 2024
| @@ -796,7 +799,9 @@ export const BuyWithCryptoModal = (props: Props) => { | |||
| })} | |||
| </span> | |||
| ) : null} | |||
| {!canBuyAsset && !isFetchingBalance && !isFetchingRoute ? ( | |||
| {canBuyAsset === false && | |||
There was a problem hiding this comment.
canBuyAsset must be computed, it starts at undefined, at that value, we don't know if it has funds or not for the tx
LautaroPetaccio
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.