feat: Use new cross chain transaction payload action #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…t/use-new-cross-chain-transaction-payload
webapp/src/config/env/dev.json
Outdated
| @@ -44,6 +44,7 @@ | |||
| "SUBGRAPH_WORKER": "https://subgraph.decentraland.zone", | |||
| "SENTRY_DSN": "https://1dc401149e1c819b8477565c9cdd9b70@o4504361728212992.ingest.sentry.io/4505743351676928", | |||
| "SQUID_API_URL": "https://testnet.v2.api.squidrouter.com/", | |||
| "SQUID_RETRY_DELAY": "3000", | |||
There was a problem hiding this comment.
3 seconds might be too much, can we use 1 or 2? wdyt?
There was a problem hiding this comment.
Sure! Changed it to 2 secs.
webapp/src/modules/item/actions.ts
Outdated
| @@ -114,7 +115,7 @@ export type BuyItemSuccessAction = ReturnType<typeof buyItemSuccess> | |||
| export type BuyItemFailureAction = ReturnType<typeof buyItemFailure> | |||
|
|
|||
| // Buy Item Cross Chain | |||
| export const TRACK_CROSS_CHAIN_TX_REQUEST = '[Request] Track Buy item cross-chain tx' | |||
| // export const TRACK_CROSS_CHAIN_TX_REQUEST = '[Request] Track Buy item cross-chain tx' | |||
There was a problem hiding this comment.
let's remove this comment since we don't need it anymore
webapp/src/modules/item/sagas.ts
Outdated
| function* handleBuyItemCrossChain(action: BuyItemCrossChainRequestAction) { | ||
| const { item, route, order } = action.payload | ||
| try { | ||
| console.log('Buying item cross chain') |
| @@ -378,7 +378,9 @@ export const BuyWithCryptoModal = (props: Props) => { | |||
| data-testid={GET_MANA_BUTTON_TEST_ID} | |||
| loading={isFetchingBalance || isBuyingAsset} | |||
| onClick={() => { | |||
| onGetMana() | |||
| // onGetMana() | |||
| console.log("Getting MANA") | |||
There was a problem hiding this comment.
Suggested change
| console.log("Getting MANA") | |
| onGetMana() |
There was a problem hiding this comment.
Fixed the function by removing the console log, the call to buy an item and adding the onGetMana call again.
LautaroPetaccio
deleted the
feat/use-new-cross-chain-transaction-payload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new version of the transactions module, which fetches and waits for pending cross chain transactions.
It removes all the logic created to work with cross chain transactions once they were launched.