Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Pagination on the Blockchain Sidetree #37

Closed
ebaizel opened this issue Oct 18, 2018 · 2 comments
Closed

Transaction Pagination on the Blockchain Sidetree #37

ebaizel opened this issue Oct 18, 2018 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@ebaizel
Copy link

ebaizel commented Oct 18, 2018

This is a question around pagination of the GET /v1.0/transactions endpoint.

https://github.com/decentralized-identity/sidetree-core/blob/master/docs/implementation.md#request-example

The sidetree protocol includes a afterBlockNumber field for paginating through GET transactions requests. This is specific to Bitcoin as the Ethereum Sidetree will be using other methods for specifying pagination location.

Could we rename that field to a more generic name? Fwiw, on Ethereum the anchor file hashes will all be saved in one smart contract and stored within an array. So the pagination value would point to an index within that array.

@ebaizel ebaizel added the question Further information is requested label Oct 18, 2018
@thehenrytsai
Copy link
Collaborator

Agree on making interface more generic. That specific API has already been reworked yesterday and the next pull request (coming out today/tomorrow) will look more generic, you can see the updated spec here if you cannot wait.

The essence of the change is that the API now will look like:

GET /<api-version>/transactions?after=<transaction-number>

@thehenrytsai
Copy link
Collaborator

Commit 0098a94 merged into master.

Closing this question, feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants