[FEATURE] Do not allow to delete areas when they have dependent space…

…s. (#5041)

* [FEATURE] Do not allow to delete areas when they have dependent spaces.

* Add changelog entry.

* [TEST] Set ParticipatoryProcess.area field in factory to nil as default.

* [REFACTOR] Remove dependency from ParticipatoryProcesses and Assembiles modules by invoking the manifest registry.

* [REFACTOR] Extract method from command to model where it belongs.

* [REFACTOR] Extract tests to the modules where they belong to.

* [REFACTOR] Use before_destroy callback so that code is more extendable.

* Rubocopify.

CHANGELOG.md

@@ -3,8 +3,9 @@
 ## [Unreleased](https://github.com/decidim/decidim/tree/HEAD)
 
 **Added**:
-- **decidim-assemblies**, **decidim-conferences**, **decidim-participatory_processes** Space CTA button text changes when no components [\#5006](https://github.com/decidim/decidim/pull/5006)
 
+- **decidim-admin**: Do not allow to delete areas when they have dependent spaces. [#5041](https://github.com/decidim/decidim/pull/5041)
+- **decidim-assemblies**, **decidim-conferences**, **decidim-participatory_processes** Space CTA button text changes when no components [\#5006](https://github.com/decidim/decidim/pull/5006)
 - **decidim-participatory_processes**: Add a select field for assign an area to participatory processes [#5011](https://github.com/decidim/decidim/pull/5011)
 - **decidim-accountability**: Also display the main scope as a filter for accountability results [#5022](https://github.com/decidim/decidim/pull/5022)
 

decidim-admin/app/commands/decidim/admin/destroy_area.rb

@@ -22,6 +22,8 @@ def initialize(area, current_user)
       def call
         destroy_area
         broadcast(:ok)
+      rescue ActiveRecord::RecordNotDestroyed
+        broadcast(:has_spaces)
       end
 
       private

decidim-admin/app/controllers/decidim/admin/areas_controller.rb

@@ -64,6 +64,10 @@ def destroy
             flash[:notice] = I18n.t("areas.destroy.success", scope: "decidim.admin")
             redirect_to areas_path
           end
+          on(:has_spaces) do
+            flash[:alert] = I18n.t("areas.destroy.has_spaces", scope: "decidim.admin")
+            redirect_to areas_path
+          end
         end
       end
 

decidim-admin/config/locales/en.yml

@@ -157,6 +157,7 @@ en:
           error: There was a problem creating a new area.
           success: Area created successfully.
         destroy:
+          has_spaces: Area has depedent spaces, it must not have dependencies in order to be deleted.
           success: Area successfully destroyed
         edit:
           title: Edit area

decidim-admin/spec/commands/decidim/admin/destroy_area_spec.rb

@@ -35,5 +35,25 @@ module Decidim::Admin
       action_log = Decidim::ActionLog.last
       expect(action_log.version).to be_present
     end
+
+    context "when a participatory process associated to a given area exist" do
+      let!(:process) { create(:participatory_process, organization: area.organization, area: area) }
+
+      it "can not be deleted" do
+        expect { subject.call }.to broadcast(:has_spaces)
+        area.reload
+        expect(area.destroyed?).to be false
+      end
+    end
+
+    context "when an assembly associated to a given area exist" do
+      let!(:process) { create(:assembly, organization: area.organization, area: area) }
+
+      it "can not be deleted" do
+        expect { subject.call }.to broadcast(:has_spaces)
+        area.reload
+        expect(area.destroyed?).to be false
+      end
+    end
   end
 end

decidim-admin/spec/system/admin_manages_organization_areas_spec.rb

@@ -75,16 +75,36 @@
       end
 
       it "can delete them" do
-        within find("tr", text: translated(area.name)) do
-          accept_confirm { click_link "Delete" }
-        end
+        click_delete_area
 
         expect(page).to have_admin_callout("successfully")
 
         within ".card-section" do
           expect(page).to have_no_content(translated(area.name))
         end
       end
+
+      context "when a participatory space associated to a given area exist" do
+        let!(:process) { create(:participatory_process, organization: area.organization, area: area) }
+
+        it "can not be deleted" do
+          click_delete_area
+          expect(area.reload.destroyed?).to be false
+          expect(page).to have_admin_callout("Area has depedent spaces")
+        end
+      end
+    end
+  end
+
+  #---------------------------------------------------
+
+  private
+
+  #---------------------------------------------------
+
+  def click_delete_area
+    within find("tr", text: translated(area.name)) do
+      accept_confirm { click_link "Delete" }
     end
   end
 end

decidim-assemblies/spec/commands/admin/destroy_area_with_assemblies_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim::Admin
+  describe DestroyArea do
+    subject { described_class.new(area, user) }
+
+    let(:organization) { create :organization }
+    let(:user) { create :user, :admin, :confirmed, organization: organization }
+    let(:area) { create :area, organization: organization }
+
+    context "when an assembly associated to a given area exist" do
+      let!(:assembly) { create(:assembly, organization: organization, area: area) }
+
+      it "can not be deleted" do
+        expect { subject.call }.to broadcast(:has_spaces)
+        expect(area.reload.destroyed?).to be false
+      end
+    end
+  end
+end

decidim-core/app/models/decidim/area.rb

@@ -21,12 +21,30 @@ class Area < ApplicationRecord
     validates :name, :organization, presence: true
     validates :name, uniqueness: { scope: [:organization, :area_type] }
 
+    before_destroy :abort_if_dependencies
+
     def self.log_presenter_class_for(_log)
       Decidim::AdminLog::AreaPresenter
     end
 
     def translated_name
       Decidim::AreaPresenter.new(self).translated_name
     end
+
+    def has_dependencies?
+      Decidim.participatory_space_registry.manifests.any? do |manifest|
+        manifest
+          .participatory_spaces
+          .call(organization)
+          .any? do |space|
+          space.respond_to?(:area) && space.decidim_area_id == id
+        end
+      end
+    end
+
+    # used on before_destroy
+    def abort_if_dependencies
+      throw(:abort) if has_dependencies?
+    end
   end
 end

decidim-participatory_processes/lib/decidim/participatory_processes/test/factories.rb

@@ -31,6 +31,7 @@
     private_space { false }
     start_date { Date.current }
     end_date { 2.months.from_now }
+    area { nil }
 
     trait :promoted do
       promoted { true }

decidim-participatory_processes/spec/commands/admin/destroy_area_with_processes_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim::Admin
+  describe DestroyArea do
+    subject { described_class.new(area, user) }
+
+    let(:organization) { create :organization }
+    let(:user) { create :user, :admin, :confirmed, organization: organization }
+    let(:area) { create :area, organization: organization }
+
+    context "when a participatory process associated to a given area exist" do
+      let!(:process) { create(:participatory_process, organization: organization, area: area) }
+
+      it "can not be deleted" do
+        expect { subject.call }.to broadcast(:has_spaces)
+        expect(area.reload.destroyed?).to be false
+      end
+    end
+  end
+end