Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discusion on applying new conferences design #4135

Closed
isaacmg410 opened this issue Sep 18, 2018 · 13 comments
Closed

Discusion on applying new conferences design #4135

isaacmg410 opened this issue Sep 18, 2018 · 13 comments
Assignees

Comments

@isaacmg410
Copy link
Contributor

Describe the bug
There are some points in the new conference design that do not behave correctly. Especially when the new design is applied to the optional components. See screenshots

Related to #3781 #3709 #3843 #4048

Expected behavior
That the components are correctly adapted to the new conference design.

Screenshots

screenshot-localhost-3000-2018 09 18-15-05-49

screenshot-localhost-3000-2018 09 18-15-14-24

screenshot-localhost-3000-2018 09 18-15-13-28

Additional context
Add any other context about the problem here.

@isaacmg410
Copy link
Contributor Author

@decidim/lot-px @furilo @Crashillo Can you check this please? In my opinion, changing the layout of all components is out of scope. Can we find a solution to integrate the components with the actual design?

cc:// @decidim/product

@Crashillo
Copy link
Member

It looks like you're bringing layout classes & containers besides the components themselves. Is that pushed to your staging? If so, I'll let you know when I take it a look.

@isaacmg410
Copy link
Contributor Author

Talked offline with @Crashillo we accorded to group main content into one container. But, this is what happens...

I am in favor of changing the menu and doing it horizontally below the image.
@decidim/product what you think?

screenshot-localhost-3000-2018 09 18-16-36-53

cc:// @furilo @Crashillo

@tramuntanal
Copy link
Contributor

I think we don't want a different layout for conferences than the one for the rest of spaces/components, it will be confusing for the user. In the image posted by @isaacmg410 we can see a menu column, then a filter column and then two results columns, first two columns are very confusing, all components are thought to take advantage of the full width.

@isaacmg410
Copy link
Contributor Author

isaacmg410 commented Sep 20, 2018

@decidim/product We should unblock this discussion

@carolromero
Copy link
Member

In order to unlock this, from @decidim/product we propose to change the vertical menu for a horizontal one.
Given that there is an EPIC of Usability improvements (#4159), and that second level menus in general cause problems because users do not see them, we will add to the list of improvements a redesign of these menus, and thus serve for Conferences and the rest of spaces.
cc/ @furilo @Crashillo

@isaacmg410
Copy link
Contributor Author

@decidim/lot-px Can you make another layout with this horitzontal menú? Or can we apply the same layout as other participatory spaces?

cc:// @decidim/product @carolromero

@carolromero
Copy link
Member

@isaacmg410 Would it be possible to test your staging by applying the design with the current menu of other participatory spaces so we make sure that by solving this we won't have other design problems?

@ghost ghost assigned isaacmg410 Sep 27, 2018
@ghost ghost added the status: WIP label Sep 27, 2018
@isaacmg410
Copy link
Contributor Author

isaacmg410 commented Sep 27, 2018

@carolromero You will find in my staging the new design applied, with the horizontal menu.
For example in this url: http://isaac.decidim.int.coditdev.net/conferences/et-consequatur

Just one thing more, if we decide that we want the menu with icons, there are missing some icons to be defined. For example: Speakers, venues, and program.
can @decidim/lot-px decide which icons to use for these entities?

cc:// @decidim/product

@carolromero
Copy link
Member

Thanks @isaacmg410, let's wait for the input from @decidim/lot-px , but I would say that regardless of the new design for the horizontal menu, the only adjustments to the Conferences specific design would be to move the CTA buttons that now appear on the left, to the right.

@isaacmg410
Copy link
Contributor Author

@carolromero Are you referring to hero's CTA buttons? or move the whole sidebar to the right?

@carolromero
Copy link
Member

@isaacmg410 I was referring to the whole sidebar
imatge

@isaacmg410
Copy link
Contributor Author

@carolromero done! :)

@ghost ghost removed the status: WIP label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants