-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discusion on applying new conferences design #4135
Comments
@decidim/lot-px @furilo @Crashillo Can you check this please? In my opinion, changing the layout of all components is out of scope. Can we find a solution to integrate the components with the actual design? cc:// @decidim/product |
It looks like you're bringing layout classes & containers besides the components themselves. Is that pushed to your staging? If so, I'll let you know when I take it a look. |
Talked offline with @Crashillo we accorded to group main content into one container. But, this is what happens... I am in favor of changing the menu and doing it horizontally below the image. cc:// @furilo @Crashillo |
I think we don't want a different layout for conferences than the one for the rest of spaces/components, it will be confusing for the user. In the image posted by @isaacmg410 we can see a menu column, then a filter column and then two results columns, first two columns are very confusing, all components are thought to take advantage of the full width. |
@decidim/product We should unblock this discussion |
In order to unlock this, from @decidim/product we propose to change the vertical menu for a horizontal one. |
@decidim/lot-px Can you make another layout with this horitzontal menú? Or can we apply the same layout as other participatory spaces? cc:// @decidim/product @carolromero |
@isaacmg410 Would it be possible to test your staging by applying the design with the current menu of other participatory spaces so we make sure that by solving this we won't have other design problems? |
@carolromero You will find in my staging the new design applied, with the horizontal menu. Just one thing more, if we decide that we want the menu with icons, there are missing some icons to be defined. For example: Speakers, venues, and program. cc:// @decidim/product |
Thanks @isaacmg410, let's wait for the input from @decidim/lot-px , but I would say that regardless of the new design for the horizontal menu, the only adjustments to the Conferences specific design would be to move the CTA buttons that now appear on the left, to the right. |
@carolromero Are you referring to hero's CTA buttons? or move the whole sidebar to the right? |
@isaacmg410 I was referring to the whole sidebar |
@carolromero done! :) |
Describe the bug
There are some points in the new conference design that do not behave correctly. Especially when the new design is applied to the optional components. See screenshots
Related to #3781 #3709 #3843 #4048
Expected behavior
That the components are correctly adapted to the new conference design.
Screenshots
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: