Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amendments can't be blocked #4826

Closed
carolromero opened this issue Feb 7, 2019 · 3 comments
Closed

Amendments can't be blocked #4826

carolromero opened this issue Feb 7, 2019 · 3 comments
Assignees
@aitorlb

Comments

@carolromero
Copy link
Member

Describe the bug
There is no way to block amendments, so you can see the existing ones but not send new ones.

Expected behavior
I expected to have a setting to block the submission of new amendments

Extra data (please complete the following information):

  • Decidim Version: 0.16
  • Decidim installation: Metadecidim

Additional context
https://meta.decidim.org/processes/bug-report/f/210/proposals/14234
@carolromero carolromero added type: bug Issues that describe a bug lot: mods labels Feb 7, 2019
@tramuntanal
Copy link
Contributor

@agustibr can you please provide further insight on the definition of this feature please?

@agustibr
Copy link
Contributor

agustibr commented Feb 18, 2019 •
edited
Loading

Hi @carolromero an admin within the Admin panel, can enable or disable the Amendment feature as described in #2292 , what you expected seams reasonable but it's out of the #2292 scope or not defined, so I wouldn't consider it a bug.

@aitorlb aitorlb assigned aitorlb and unassigned aitorlb Feb 18, 2019
@aitorlb
Copy link
Contributor

aitorlb commented Feb 18, 2019

Hi @carolromero ,
All amendments features (except proposal control version) depend upon the first point of #2292:

  • Amendment feature has to be activated in the proposal component admin panel

It seems that what you expected is to be able to activate amendments and enable/disable amendment creation. I agree with @agustibr that this behaviour was undefined at the developing stage.

@tramuntanal tramuntanal removed lot: mods type: bug Issues that describe a bug labels Mar 11, 2019
This was referenced Apr 8, 2019
Closed
Merged
mrcasals pushed a commit that referenced this issue Apr 9, 2019
@mrcasals
Fix: show existing amendments when amendments feature is disabled (#5070
4af26af 
)

#### 🎩 What? Why?
Existing amendments were being hidden from the public view when `amendments_enabled` setting was disabled.
This caused the following problems:
- The admin had no way of disabling amendment creation while still show existing amendments.
- The counter of the proposals filters (`ProposalSearch`) was counting amendments that were not being shown, which led to believe that the filters weren't working properly.

This PR makes the necessary changes as to not hide existing amendments from the public view if the amendments feature is disabled.

#### 📌 Related Issues
- Fixes #4826
- Fixes #5056

#### 📋 Subtasks
- [x] Add `CHANGELOG` entry
- [x] Modify seeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aitorlb aitorlb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@oriolgual @tramuntanal @agustibr @carolromero @aitorlb