Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing notification for registered participants when invited to a private space #5476

Closed
carolromero opened this issue Nov 6, 2019 · 5 comments · Fixed by #6011
Closed
Labels
type: bug Issues that describe a bug

Comments

@carolromero
Copy link
Member

Describe the bug
When inviting participants by uploading a csv file, no notifications are sent to already registered participants.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'admin/participatory_processes/NAME/participatory_space_private_users/csv_import/new'
  2. Click on 'import via CSV'
  3. Upload CSV file
  4. Registered participants do not receive notification

Expected behavior
I would expect to receive an email notification that I've been invited to participate in a private space.

Extra data (please complete the following information):

  • Decidim Version: 0.19
  • Decidim installation: Metadecidim

Additional context
Related to #5304

@carolromero carolromero added type: bug Issues that describe a bug lot: mods labels Nov 6, 2019
@jesusdb
Copy link
Contributor

jesusdb commented Mar 23, 2020

Hello, @carolromero,

When I try to reproduce the bug, I actually do receive an email notification:
imagen

@jesusdb
Copy link
Contributor

jesusdb commented Apr 23, 2020

Hello, @decidim/product,

I couldn't reproduce the bug earlier because I received the email. I tried it in production and locally, using my own email. Then I received a CSV file with specific emails, and I also tested these cases:

In production

  1. ✔️ Only my email
  2. ✔️ My email and a coworker's
  3. ❌ Specific emails from the CSV provided
  4. ❌ CSV file emails with my email*

*An email was sent to me, but not to the others.

Locally

Using letter_opener
  • All emails were sent
Using Sidekiq and Sendgrid service
  • All emails were sent

Looking at the logs, no errors were raised. I found out that any user invited previously to the application, will be able to receive the email, but if they signed up by themselves, they won't. Unluckily I didn't notice before locally because all the users were saved as if they were registered by an invitation.

Since this is how Decidim works, I would need to know if this is not really the desired behavior, or if you want the app to handle this case; being able to send emails no matter if the user was not invited to sign up, only if they were invited to a private participatory space.

@andreslucena
Copy link
Member

but if they signed up by themselves, they won't

Yes, this is the bug that we're reporting. If a participant has registered by themselves and is invited to a private participatory space she should receive an invitation.

@jesusdb
Copy link
Contributor

jesusdb commented Apr 28, 2020

@andreslucena, the bug report is this:

When inviting participants by uploading a csv file, no notifications are sent to already registered participants.

And the bug report is not completely accurate since there are participants already registered that do receive the email notification.

And I said this:

I found out that any user invited previously to the application, will be able to receive the email, but if they signed up by themselves, they won't.

The problem is not if they were registered before or not, the problem is how they were registered before.

So, what I was asking in my last comment was if you would like to change the invitation behavior so the invitation could be sent to users signed up by themselves only in this case (when uploading the CSV file), or if you want the app to be able to send the invitation to these users anywhere else.

@andreslucena
Copy link
Member

@jesusdb regarding your questions, I 100% agree with #6011 (comment)

Please let's keep the discussion there so it's easier to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that describe a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants