Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Fix iframes stripped from admin entered proposals, meetings and debates' to v0.26 #10559

Merged
merged 1 commit into from
May 4, 2023
Merged

Backport 'Fix iframes stripped from admin entered proposals, meetings and debates' to v0.26 #10559

merged 1 commit into from
May 4, 2023

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport #10466 to v0.26

♥️ Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: debates module: meetings module: proposals type: fix PRs that implement a fix for a bug labels Mar 15, 2023
fblupi
fblupi reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing as there is no decidim_sanitize_editor_admin in 0.26. Maybe we shouldn't backport it to 0.26

@alecslupu
Copy link
Contributor Author

26

You are right ... We cannot port it to 0.26 without having a api change.

Ditching this PR.

@alecslupu alecslupu closed this Mar 16, 2023
@alecslupu alecslupu reopened this Apr 22, 2023
@alecslupu
Copy link
Contributor Author

Since we have decided that we will backport the decidim_sanitize_editor_admin as per #10746 (comment). We need to apply this PR in order to successfuly backport #10746.

As per #10130 (comment) decidim debates has been fixed by this Backport PR and is a dependency for #10746

@alecslupu alecslupu mentioned this pull request Apr 22, 2023
Merged
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Apr 26, 2023
@alecslupu alecslupu moved this from Pending review from Product to Backport pending in Maintainers Apr 26, 2023
@ahukkanen
Copy link
Contributor

@alecslupu Could you rebase this backport please? I have just merged #10764 which introduces the missing method.

@alecslupu alecslupu force-pushed the backport/0.26/fix-iframes-stripped-from-admi-10466 branch from 48eb530 to 9b7b42d Compare May 2, 2023 10:46
@alecslupu alecslupu force-pushed the backport/0.26/fix-iframes-stripped-from-admi-10466 branch from 9b7b42d to 6bfbb4d Compare May 2, 2023 12:10
@alecslupu alecslupu requested review from a team and fblupi May 2, 2023 12:57
@fblupi fblupi merged commit 78ee3d1 into release/0.26-stable May 4, 2023
Maintainers automation moved this from Backport pending to Done May 4, 2023
@fblupi fblupi deleted the backport/0.26/fix-iframes-stripped-from-admi-10466 branch May 4, 2023 08:19
@alecslupu alecslupu added this to the 0.26.7 milestone Jul 14, 2023
@alecslupu alecslupu mentioned this pull request Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblupi fblupi fblupi approved these changes

Assignees

@fblupi fblupi

Labels
backport Pull Requests that are a backport for a fixed bug module: debates module: meetings module: proposals type: fix PRs that implement a fix for a bug
Projects
Maintainers
Done
Milestone
0.26.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alecslupu @ahukkanen @fblupi