Backport 'Fix Video embeds are not shown in short_description field' to v0.26 #10746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
backport
alecslupu
force-pushed
the
backport/0.26/fix-video-embeds-are-not-shown-10467
branch
2 times, most recently
from
16fa272
to
56be10f
Compare
ahukkanen
reviewed
Apr 20, 2023
decidim-consultations/spec/scrubbers/decidim/consultations/question_title_scrubber_spec.rb
Show resolved
Hide resolved
alecslupu
force-pushed
the
backport/0.26/fix-video-embeds-are-not-shown-10467
branch
2 times, most recently
from
2b07cf3
to
87f847e
Compare
alecslupu
commented
Apr 22, 2023
|
Since we have decided that we need to backport the The following PRs are required as dependencies:
Considering this is not a simple function that is being added, I really need other opinions from other @decidim/maintainers |
alecslupu
moved this from Pending review from Product
to Backport pending
in Maintainers
|
@alecslupu Could you rebase this backport please? I have just merged #10764 which introduces the missing method. There are also likely also some changes needed in the specs because we do not have iframe disabling functionality in 0.26. |
alecslupu
force-pushed
the
backport/0.26/fix-video-embeds-are-not-shown-10467
branch
from
f1b6aeb
to
2b06818
Compare
|
@alecslupu There are some conflicts in this PR, could you resolve them please? Also some of the specs related to displaying iframes are failing. I'm not sure if the failures are correct or if the tests need to be changed, could you also have a look at that? |
alecslupu
force-pushed
the
backport/0.26/fix-video-embeds-are-not-shown-10467
branch
from
2b06818
to
90361b0
Compare
* Fix: Video embeds are not shown in short_description field * Add test for ParticipatoryProcess * Add admin_support for Blog * Add decidim-budget admin sanitization * Add decidim-consultations * Enable iframes for decidim-pages * Enable iframes for decidim-proposals * Enable iframes for decidim-debates * Enable iframes for decidim-sortitions * Enable full editor in decidim-elections * Enable full content in decidim-surveys * revert sortitions * Running Linters * Revert proposals fields * Fix Election spec * Fix decidim assemblies * Implement new restrictions * Fix the scrubbers * Add more restrictions to the scrubber scrubber * Sort the restricted tags * Revert strip tags for questions in consultations * Fix consultations change requests
alecslupu
force-pushed
the
backport/0.26/fix-video-embeds-are-not-shown-10467
branch
from
90361b0
to
06302dd
Compare
ahukkanen
requested changes
May 6, 2023
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
ahukkanen
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #10467 to v0.26