Backport 'Fix edit form in intitiatives' to v0.26

[alecslupu]

🎩 What? Why?

Backport #10724 to v0.26

♥️ Thank you!

[ahukkanen]

Can you please rebase this PR? There is a conflict because of #10786.

[ahukkanen]

@alecslupu The tests are failing here. It is trying to call .merge() for a string on this line:

decidim/decidim-core/lib/decidim/translatable_attributes.rb

Line 59 in 9b8c347

public_send("#{name}=", field.merge(locale => super(value)))

The problem I believe is that the hash coercer in Virtus does not convert a string into a hash, you can try this in the console (using 0.26):

> Virtus::Attribute.build(Virtus::Attribute::Hash).coerce("Foobar")

In 0.27 it works somehow differently with the new attribute system as we don't have this exception happening.

There are still some issue with the tests when using Virtus.

[ahukkanen]

I investigated the problem a bit and I think there is a problem with the original fix that this is backporting.

This would be the proper way to handle the problem where the data is stored in multilingual format but the form only shows the inputs for the current locale:

decidim/decidim-proposals/app/forms/decidim/proposals/proposal_wizard_create_step_form.rb

Lines 26 to 27 in 4eb9dec

	self.title = translated_attribute(model.title)
	self.body = translated_attribute(model.body)

And when saving the record (I believe this is already done in initiatives):

decidim/decidim-proposals/app/commands/decidim/proposals/create_proposal.rb

Lines 59 to 61 in 4eb9dec

	title: {
	I18n.locale => title_with_hashtags
	},

[alecslupu]

I investigated the problem a bit and I think there is a problem with the original fix that this is backporting.

This would be the proper way to handle the problem where the data is stored in multilingual format but the form only shows the inputs for the current locale:

decidim/decidim-proposals/app/forms/decidim/proposals/proposal_wizard_create_step_form.rb

Lines 26 to 27 in 4eb9dec

	self.title = translated_attribute(model.title)
	self.body = translated_attribute(model.body)

And when saving the record (I believe this is already done in initiatives):

decidim/decidim-proposals/app/commands/decidim/proposals/create_proposal.rb

Lines 59 to 61 in 4eb9dec

	title: {
	I18n.locale => title_with_hashtags
	},

@ahukkanen thanks for the input on fixing this. 35d372f fixes the issue

[ahukkanen]

@ahukkanen thanks for the input on fixing this. 35d372f fixes the issue

Thanks @alecslupu but I think we need to do the same change at develop too before the backport. Using translated_attribute on the form is incorrect if the UI does not show the translated fields.

Why the current code works at develop is due to this backwards compatibility functionality:

decidim/decidim-core/lib/decidim/attributes/hash.rb

Lines 25 to 28 in e4f5f83

	# This preserves backwards compatibility for non-hash values e.g. with
	# the admin hero content block which expects the images container object
	# as the default value when building the admin form.
	return value unless value.is_a?(::Hash)

In the core modules we should should avoid relying on backwards compatibility features.