Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix initiative creation missing form fields' to v0.26 #10786

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #10006 to v0.26

鈾ワ笍 Thank you!

* Fix initiative creation missing form fields

* Add new form fields to spec

* Replace single quotes with double quotes

* Fix failing test

* Improve initiative create and edit form

Add form_field for initiative_type to create form
Move form_field for state to the end on edit form
add help text to author-select
fix specs

* normalize en.yml

* Add hidden field for initiative_type

* Update decidim-initiatives/config/locales/en.yml

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>

* Fix order of fields

* Update decidim-initiatives/app/controllers/decidim/initiatives/create_initiative_controller.rb

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>

* Fix spec

* Add missing hashtag to creation command

* Add missing trailing newline

---------

Co-authored-by: Andr茅s Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: initiatives type: fix PRs that implement a fix for a bug labels Apr 25, 2023
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Apr 25, 2023
@alecslupu alecslupu moved this from Pending review from Product to Backport pending in Maintainers Apr 25, 2023
@alecslupu alecslupu requested a review from a team April 25, 2023 18:30
@ahukkanen ahukkanen merged commit 1deafe9 into release/0.26-stable Apr 26, 2023
8 checks passed
Maintainers automation moved this from Backport pending to Done Apr 26, 2023
@ahukkanen ahukkanen deleted the backport/0.26/fix-initiative-creation-missin-10006 branch April 26, 2023 06:30
@alecslupu alecslupu added this to the 0.26.7 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: initiatives type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants