Backport 'Verify modules are installed in StatsParticipantsCount query' to v0.26 #11158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
backport
andreslucena
approved these changes
Jul 12, 2023
|
Oh I approved it but then I saw the failing checks @alecslupu - we're using an API that doesn't exists in v0.26. We should change it to another strategy (like with the defined? keyword) |
I have a better idea: Implement the functionality in 0.26, as it seems that is a fix that has not been backported. Please check: #11168 |
@alecslupu it was merge already, can you merge with the release branch 🙏🏽 ? Thanks |
… backport/0.26/verify-modules-are-installed-i-11138
andreslucena
approved these changes
Jul 12, 2023
andreslucena
deleted the
backport/0.26/verify-modules-are-installed-i-11138
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #11138 to v0.26