Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix uninitialized constant errors with custom set of modules' to v0.26 #11168

Conversation

alecslupu
Copy link
Contributor

馃帺 What? Why?

Backport #9577 to v0.26

鈾ワ笍 Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug labels Jul 12, 2023
@alecslupu alecslupu requested a review from a team July 12, 2023 10:18
@alecslupu alecslupu added this to the 0.26.8 milestone Jul 12, 2023
* Fix uninitialized constant errors for unexisting modules

* Add specs for the dependency resolver

* Document the method without documentation

* Remove unnecessary commented code

* DRY comments

* Reset the resolver cache during the tests

* Add debug messages for CI

* More debug

* Try relative paths to the git gems in the custom Gemfile

* Print out the generated Gemfile.lock

* Revert "Try relative paths to the git gems in the custom Gemfile"

This reverts commit bb2f675.

* Print out the root dirs in the test debug

* Revert "Print out the root dirs in the test debug"

This reverts commit 06983f1.

* Move debug to its own spec

* Print out bundle(r) and gem related ENV vars

* More debug logging

* Remove the unnecessary yield argument

* Fix syntax error

* Add debug for the dummy lockfile generation

* Report bundle not frozen during the custom Gemfile specs

* Remove the debug output from the custom Gemfile specs

* Add specs for

* Add missing return value YARD docs

* Rubocop auto-correct
@alecslupu alecslupu force-pushed the backport/0.26/fix-uninitialized-constant-err-9577 branch from 1ff9ff3 to 7a8662f Compare July 12, 2023 11:06
@alecslupu alecslupu added this to Pending review from Product in Maintainers via automation Jul 12, 2023
@andreslucena andreslucena merged commit 3c2325c into release/0.26-stable Jul 12, 2023
47 of 48 checks passed
Maintainers automation moved this from Pending review from Product to Done Jul 12, 2023
@andreslucena andreslucena deleted the backport/0.26/fix-uninitialized-constant-err-9577 branch July 12, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants