Raise exception in UserTimelineController if no user with the nickname provided
#11465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
requested changes
Aug 9, 2023
decidim-core/app/controllers/decidim/user_timeline_controller.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
added
type: fix
fblupi
added a commit
that referenced
this pull request
Aug 10, 2023
…ame provided (#11465) * Raise exception in timeline controller if no user with the nickname provided * Update decidim-core/app/controllers/decidim/user_timeline_controller.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
added a commit
that referenced
this pull request
Aug 14, 2023
…he nickname provided' to v0.26 (#11470) * Raise exception in `UserTimelineController` if no user with the nickname provided (#11465) * Raise exception in timeline controller if no user with the nickname provided * Update decidim-core/app/controllers/decidim/user_timeline_controller.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Fix spec --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
|
Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Raise
ActionController::RoutingErrorexception inUserTimelineControllerif no user with the nickname provided📌 Related Issues
Testing
/profiles/non_existing_user_nickname/timelineand see a 404 Not Found page shown.