Fix password confirm validation error message

decidim-core/app/forms/decidim/account_form.rb

@@ -24,7 +24,7 @@ class AccountForm < Form
     validates :nickname, presence: true, format: { with: Decidim::User::REGEXP_NICKNAME }
 
     validates :nickname, length: { maximum: Decidim::User.nickname_max_length, allow_blank: true }
-    validates :password, confirmation: true
+    validates :password, confirmation: { message: '"Confirm your password" does not match Password' }
     validates :password, password: { name: :name, email: :email, username: :nickname }, if: -> { password.present? }
     validates :password_confirmation, presence: true, if: :password_present
     validates :avatar, passthru: { to: Decidim::User }

decidim-core/spec/forms/account_form_spec.rb

@@ -155,6 +155,19 @@ module Decidim
       end
     end
 
+    describe "password_confirmation" do
+      context "when the password confirmaiton does not match" do
+        let(:password_confirmation) { "aaaabbbbcccc" }
+
+        it { is_expected.to be_invalid }
+
+        it "adds the correct error" do
+          subject.valid?
+          expect(subject.errors[:password_confirmation]).to include('"Confirm your password" does not match Password')
+        end
+      end
+    end
+
     describe "personal_url" do
       context "when it doesn't start with http" do
         let(:personal_url) { "example.org" }