Fix password confirm validation error message

[greenwoodt]

🎩 What? Why?

This is a password confirmation alert message change to allow the alert to be more clearer according to the original issuer #11283.

An original PR to this issue was moved from 0.28 to 0.27: #11534

📌 Related Issues

Link your PR to an issue

• Fixes Sign up error message if ' Confirm password does not match Password ' could be typed clearer by adding quotation marks #11284

Testing

1. Head over to Sign in/Log in
2. Click create an account
3. Fill the form
4. Purposely create different passwords in the confirmation field and hit enter
5. See the the error output has quotes

📷 Screenshots

♥️ Thank you!

[greenwoodt]

I have updated changes to allow the error message to appear both as a user that has logged in and wishes to change their password and sign up from the perspective of a new user however, the error message repeats itself twice in decidim-core/app/forms/decidim/registration_form.rbas seen in the sc below:

[andreslucena]

I have updated changes to allow the error message to appear both as a user that has logged in and wishes to change their password and sign up from the perspective of a new user however, the error message repeats itself twice in decidim-core/app/forms/decidim/registration_form.rbas seen in the sc below:

@greenwoodt I check out this error and I saw that this is actually done because we're using full_messages and adding the error message in the flash alert. For what I could see, this is something that we're only doing in this form, so for consistency we should leave the generic error message in the flash alert. Mind that the validation error is shown in the form itself:

For changing this, you need to change the flash.now[:alert] in decidim-core/app/controllers/decidim/devise/registrations_controller.rb. This is what I have in mind:

diff --git a/decidim-core/app/controllers/decidim/devise/registrations_controller.rb b/decidim-core/app/controllers/decidim/devise/registrations_controller.rb
index ba62d5330b..17744906f9 100644
--- a/decidim-core/app/controllers/decidim/devise/registrations_controller.rb
+++ b/decidim-core/app/controllers/decidim/devise/registrations_controller.rb
@@ -39,7 +39,7 @@ module Decidim
           end
 
           on(:invalid) do
-            flash.now[:alert] = @form.errors.full_messages.join(", ") if @form.errors.full_messages.any?
+            flash.now[:alert] = t("error", scope: "decidim.devise.registrations.create")
             render :new
           end
         end
diff --git a/decidim-core/config/locales/en.yml b/decidim-core/config/locales/en.yml
index 25a425f31b..3ad9735657 100644
--- a/decidim-core/config/locales/en.yml
+++ b/decidim-core/config/locales/en.yml
@@ -534,6 +534,8 @@ en:
           subtitle: Please fill in the following form in order to complete the sign up
           username_help: Public name that appears on your posts. With the aim of guaranteeing the anonymity, can be any name.
       registrations:
+        create:
+          error: There was a problem creating your account.
         new:
           already_have_an_account?: Already have an account?
           newsletter: Receive an occasional newsletter with relevant information

[andreslucena]

I have a couple suggestions and also a change in the flash alert. Can you check it out please?

[alecslupu]

Functionality checked, and works as advertised.

@greenwoodt, can you have a look on failing specs?

[greenwoodt]

@alecslupu and @andreslucena Apologies for taking some time ironing out the tests on this PR but upon closer inspection the release/0.27-stable branch is actually broken with a Catalan translation to "Sign in" on the Core (system specs) / Tests this should be fixed with commit: 2a37840

[greenwoodt]

Changes have made also been made to the flash error message to simplify the Rspec test in the decidim-core/spec/controllers/registrations_controller_spec.rb (requested by @andreslucena)

Feel free to review anytime @alecslupu

[andreslucena]

Just a small change and we're good to go

[andreslucena]

Also, as we're changing how we're handling the errors in this form, I think we should also change how this flash alert works in develop, just to keep it consistent within versions

decidim/decidim-core/app/controllers/decidim/devise/registrations_controller.rb

Line 42 in d15dcd6

flash.now[:alert] = @form.errors.full_messages.join(", ") if @form.errors.full_messages.any?

We can do it once this is merged

[greenwoodt]

Also, as we're changing how we're handling the errors in this form, I think we should also change how this flash alert works in develop, just to keep it consistent within versions

decidim/decidim-core/app/controllers/decidim/devise/registrations_controller.rb

Line 42 in d15dcd6

flash.now[:alert] = @form.errors.full_messages.join(", ") if @form.errors.full_messages.any?

We can do it once this is merged

Ok!

[andreslucena]

LGTM! As I was involved in the code, I'll ask for @alecslupu review before merging

[alecslupu]

LGTM